You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Travis Martensen (JIRA)" <ji...@codehaus.org> on 2008/07/15 01:08:27 UTC

[jira] Created: (MANT-44) Generated ant copy commands in package target point to hard-coded local repository instead of ${maven.repo.local}

Generated ant copy commands in package target point to hard-coded local repository instead of ${maven.repo.local}
-----------------------------------------------------------------------------------------------------------------

                 Key: MANT-44
                 URL: http://jira.codehaus.org/browse/MANT-44
             Project: Maven 2.x Ant Plugin
          Issue Type: Bug
    Affects Versions: 2.1
         Environment: Windows XP Professional SP2
            Reporter: Travis Martensen


When generating a build file, copy commands in the "package" target are hard-coded to the local repository, even with no hard-coded paths in the POM.  I'm guessing the hard-coded path should be replaced with ${maven.repo.local}.

Example:

{code:xml}
  <target name="package" depends="compile,test" description="Package the application">
    <mkdir dir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
    <copy file="C:\Documents and Settings\<username>\.m2\repository\org\apache\wicket\wicket\1.3.3\wicket-1.3.3.jar" 
          todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
    <copy file="C:\Documents and Settings\<username>\.m2\repository\org\apache\wicket\wicket-extensions\1.3.3\wicket-extensions-1.3.3.jar" 
          todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
    <copy file="C:\Documents and Settings\<username>\.m2\repository\org\slf4j\slf4j-log4j12\1.4.2\slf4j-log4j12-1.4.2.jar" 
          todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
    <copy file="C:\Documents and Settings\<username>\.m2\repository\log4j\log4j\1.2.14\log4j-1.2.14.jar" 
          todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
    <copy file="C:\Documents and Settings\<username>\.m2\repository\org\hibernate\hibernate\3.2.6.ga\hibernate-3.2.6.ga.jar" 
          todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
    <copy file="C:\Documents and Settings\<username>\.m2\repository\org\springframework\spring\2.5.4\spring-2.5.4.jar" 
          todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
    <copy file="C:\Documents and Settings\<username>\.m2\repository\org\apache\wicket\wicket-spring\1.3.3\wicket-spring-1.3.3.jar" 
          todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
    <copy file="C:\Documents and Settings\<username>\.m2\repository\org\apache\wicket\wicket-spring-annot\1.3.3\wicket-spring-annot-1.3.3.jar" 
          todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
    <copy file="C:\Documents and Settings\<username>\.m2\repository\org\acegisecurity\acegi-security\1.0.7\acegi-security-1.0.7.jar" 
          todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
    <copy file="C:\Documents and Settings\<username>\.m2\repository\org\apache\wicket\wicket-security\swarm\1.3.0\swarm-1.3.0.jar" 
          todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
    <war destfile="${maven.build.dir}/${maven.build.finalName}.war" 
         basedir="${maven.build.outputDir}" 
         compress="true" 
         webxml="${basedir}/src/main/webapp/WEB-INF/web.xml">
      <lib dir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
      <classes dir="${maven.build.outputDir}"/>
      <webinf dir="${basedir}/src/main/webapp/WEB-INF" 
              excludes="web.xml"/>
      <fileset dir="${basedir}/src/main/webapp"/>
    </war>
  </target>
{code} 



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (MANT-44) Generated ant copy commands in package target point to hard-coded local repository instead of ${maven.repo.local}

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MANT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=141775#action_141775 ] 

Dennis Lundberg commented on MANT-44:
-------------------------------------

Confirmed.

I have a solution in the works, just need to create some tests for it.

> Generated ant copy commands in package target point to hard-coded local repository instead of ${maven.repo.local}
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: MANT-44
>                 URL: http://jira.codehaus.org/browse/MANT-44
>             Project: Maven 2.x Ant Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1
>         Environment: Windows XP Professional SP2
>            Reporter: Travis Martensen
>
> When generating a build file, copy commands in the "package" target are hard-coded to the local repository, even with no hard-coded paths in the POM.  I'm guessing the hard-coded path should be replaced with ${maven.repo.local}.
> Example:
> {code:xml}
>   <target name="package" depends="compile,test" description="Package the application">
>     <mkdir dir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\apache\wicket\wicket\1.3.3\wicket-1.3.3.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\apache\wicket\wicket-extensions\1.3.3\wicket-extensions-1.3.3.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\slf4j\slf4j-log4j12\1.4.2\slf4j-log4j12-1.4.2.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\log4j\log4j\1.2.14\log4j-1.2.14.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\hibernate\hibernate\3.2.6.ga\hibernate-3.2.6.ga.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\springframework\spring\2.5.4\spring-2.5.4.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\apache\wicket\wicket-spring\1.3.3\wicket-spring-1.3.3.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\apache\wicket\wicket-spring-annot\1.3.3\wicket-spring-annot-1.3.3.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\acegisecurity\acegi-security\1.0.7\acegi-security-1.0.7.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\apache\wicket\wicket-security\swarm\1.3.0\swarm-1.3.0.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <war destfile="${maven.build.dir}/${maven.build.finalName}.war" 
>          basedir="${maven.build.outputDir}" 
>          compress="true" 
>          webxml="${basedir}/src/main/webapp/WEB-INF/web.xml">
>       <lib dir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>       <classes dir="${maven.build.outputDir}"/>
>       <webinf dir="${basedir}/src/main/webapp/WEB-INF" 
>               excludes="web.xml"/>
>       <fileset dir="${basedir}/src/main/webapp"/>
>     </war>
>   </target>
> {code} 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Closed: (MANT-44) Generated ant copy commands in package target point to hard-coded local repository instead of ${maven.repo.local}

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MANT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann closed MANT-44.
---------------------------------

         Assignee: Benjamin Bentmann  (was: Dennis Lundberg)
       Resolution: Fixed
    Fix Version/s: 2.1.1

Fixed in [r691629|http://svn.apache.org/viewvc?view=rev&revision=691629], SNAPSHOT deployed.

Dennis, could you review the fix and tweak it in case the solution you mentioned is cleaner or more robust?

> Generated ant copy commands in package target point to hard-coded local repository instead of ${maven.repo.local}
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: MANT-44
>                 URL: http://jira.codehaus.org/browse/MANT-44
>             Project: Maven 2.x Ant Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1
>         Environment: Windows XP Professional SP2
>            Reporter: Travis Martensen
>            Assignee: Benjamin Bentmann
>             Fix For: 2.1.1
>
>
> When generating a build file, copy commands in the "package" target are hard-coded to the local repository, even with no hard-coded paths in the POM.  I'm guessing the hard-coded path should be replaced with ${maven.repo.local}.
> Example:
> {code:xml}
>   <target name="package" depends="compile,test" description="Package the application">
>     <mkdir dir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\apache\wicket\wicket\1.3.3\wicket-1.3.3.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\apache\wicket\wicket-extensions\1.3.3\wicket-extensions-1.3.3.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\slf4j\slf4j-log4j12\1.4.2\slf4j-log4j12-1.4.2.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\log4j\log4j\1.2.14\log4j-1.2.14.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\hibernate\hibernate\3.2.6.ga\hibernate-3.2.6.ga.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\springframework\spring\2.5.4\spring-2.5.4.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\apache\wicket\wicket-spring\1.3.3\wicket-spring-1.3.3.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\apache\wicket\wicket-spring-annot\1.3.3\wicket-spring-annot-1.3.3.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\acegisecurity\acegi-security\1.0.7\acegi-security-1.0.7.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <copy file="C:\Documents and Settings\<username>\.m2\repository\org\apache\wicket\wicket-security\swarm\1.3.0\swarm-1.3.0.jar" 
>           todir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>     <war destfile="${maven.build.dir}/${maven.build.finalName}.war" 
>          basedir="${maven.build.outputDir}" 
>          compress="true" 
>          webxml="${basedir}/src/main/webapp/WEB-INF/web.xml">
>       <lib dir="${maven.build.dir}/${maven.build.finalName}/WEB-INF/lib"/>
>       <classes dir="${maven.build.outputDir}"/>
>       <webinf dir="${basedir}/src/main/webapp/WEB-INF" 
>               excludes="web.xml"/>
>       <fileset dir="${basedir}/src/main/webapp"/>
>     </war>
>   </target>
> {code} 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira