You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/25 09:55:06 UTC

[GitHub] [incubator-apisix] shoogoome opened a new pull request #1909: Resolves #1902 Different upstreams use different discovery and customize the discovery schema

shoogoome opened a new pull request #1909:
URL: https://github.com/apache/incubator-apisix/pull/1909


   ### What this PR does / why we need it:
   1. Now discovery can only use one of them at the same time
   2. Parameter can only use ‘service_ name’, this does not fit all service discovery
   
   ### Pre-submission checklist:
   
   - modify schema_ def.lua to load it into the discovery schema to adapt to the customized parameters of different discovery.
   - modify config.yaml Type of file discovery (changed to list)
   - modify the balancer.lua to get IP according to the specified discovery
   - modify discovery/init.lua, load them in the discovery resgistered in the config.yaml
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] moonming commented on pull request #1909: Resolves #1902 Different upstreams use different discovery and customize the discovery schema

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #1909:
URL: https://github.com/apache/incubator-apisix/pull/1909#issuecomment-663857782


   @shoogoome please add test cases, thx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1909: Resolves #1902 Different upstreams use different discovery and customize the discovery schema

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1909:
URL: https://github.com/apache/incubator-apisix/pull/1909#issuecomment-664208283


   @shoogoome I think we can support more `discovery` service in this way, just develop a new plugin.
   
   I think this way is flexible and simpler.
   
   Here is the source code: https://github.com/apache/incubator-apisix/blob/master/apisix/plugins/example-plugin.lua#L68
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] juzhiyuan commented on pull request #1909: Resolves #1902 Different upstreams use different discovery and customize the discovery schema

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1909:
URL: https://github.com/apache/incubator-apisix/pull/1909#issuecomment-663839975


   Why there will have so many same PRs?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis edited a comment on pull request #1909: Resolves #1902 Different upstreams use different discovery and customize the discovery schema

Posted by GitBox <gi...@apache.org>.
membphis edited a comment on pull request #1909:
URL: https://github.com/apache/incubator-apisix/pull/1909#issuecomment-664208283


   @shoogoome I think we can support more `discovery` service in this way, just develop a new plugin.
   I think this way is flexible and simpler. 
   
   You can take a look at this example: https://github.com/apache/incubator-apisix/blob/master/apisix/plugins/example-plugin.lua#L68
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] shoogoome commented on pull request #1909: Resolves #1902 Different upstreams use different discovery and customize the discovery schema

Posted by GitBox <gi...@apache.org>.
shoogoome commented on pull request #1909:
URL: https://github.com/apache/incubator-apisix/pull/1909#issuecomment-664116222


   @moonming 
   Taking my company as an example, different service discovery systems have been produced under long-term operation, and different service discovery systems have been used by new and old businesses (although the new business is unified now), so I need the gateway to have the ability to use multiple service discovery systems~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] moonming commented on pull request #1909: Resolves #1902 Different upstreams use different discovery and customize the discovery schema

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #1909:
URL: https://github.com/apache/incubator-apisix/pull/1909#issuecomment-664089171


   > Now discovery can only use one of them at the same time
   
   @shoogoome I'm not quite sure why we need to support multiple service discoveries at the same time, can you explain the benefits of doing so? thank you


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org