You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Kurt Deschler (Code Review)" <ge...@cloudera.org> on 2019/10/10 22:00:44 UTC

[Impala-ASF-CR] IMPALA-4025: Part 2: Add percentile disc aggregation function

Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/9777 )

Change subject: IMPALA-4025: Part 2: Add percentile_disc aggregation function
......................................................................


Patch Set 10:

(1 comment)

This looks fairly complex as far as rewrites go. Curious why this was not added to BE instead? When we consolidate frontends, this will need to reconcile any rewrites with what Hive supports.

http://gerrit.cloudera.org:8080/#/c/9777/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:

http://gerrit.cloudera.org:8080/#/c/9777/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@2133
PS10, Line 2133:   }
Add test with int constant type



-- 
To view, visit http://gerrit.cloudera.org:8080/9777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacef7b3fcd74c4c73d88400ce27307c3baa0121e
Gerrit-Change-Number: 9777
Gerrit-PatchSet: 10
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Oct 2019 22:00:44 +0000
Gerrit-HasComments: Yes