You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/10/06 18:21:08 UTC
Review Request 26366: Admin : Clean up controllers/ldap API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26366/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-7649
https://issues.apache.org/jira/browse/AMBARI-7649
Repository: ambari
Description
-------
The controllers/ldap API has been replaced with ldap_sync_events. Since the controllers API was never part of a release we should remove it now if it is not needed.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ControllerResourceDefinition.java 55e6502
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 2676fd3
ambari-server/src/main/java/org/apache/ambari/server/api/services/ControllerService.java 6d20a93
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 2fa38c5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ControllerResourceProvider.java afb9ae9
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ControllerType.java 82b6eac
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6cf34ca
ambari-server/src/main/resources/key_properties.json ef698c5
ambari-server/src/main/resources/properties.json b99ede5
Diff: https://reviews.apache.org/r/26366/diff/
Testing
-------
All tests pass ...
Results :
Tests run: 2076, Failures: 0, Errors: 0, Skipped: 16
...
[INFO] Executed tasks
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:42.367s
[INFO] Finished at: Mon Oct 06 11:31:04 EDT 2014
[INFO] Final Memory: 38M/309M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 26366: Admin : Clean up controllers/ldap API
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Oct. 6, 2014, 1:48 p.m., Jonathan Hurley wrote:
> > Ship It!
Too funny; no tests :)
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26366/#review55535
-----------------------------------------------------------
On Oct. 6, 2014, 12:21 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26366/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2014, 12:21 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-7649
> https://issues.apache.org/jira/browse/AMBARI-7649
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The controllers/ldap API has been replaced with ldap_sync_events. Since the controllers API was never part of a release we should remove it now if it is not needed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ControllerResourceDefinition.java 55e6502
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 2676fd3
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ControllerService.java 6d20a93
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 2fa38c5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ControllerResourceProvider.java afb9ae9
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ControllerType.java 82b6eac
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6cf34ca
> ambari-server/src/main/resources/key_properties.json ef698c5
> ambari-server/src/main/resources/properties.json b99ede5
>
> Diff: https://reviews.apache.org/r/26366/diff/
>
>
> Testing
> -------
>
> All tests pass ...
>
> Results :
>
> Tests run: 2076, Failures: 0, Errors: 0, Skipped: 16
>
> ...
>
>
> [INFO] Executed tasks
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:42.367s
> [INFO] Finished at: Mon Oct 06 11:31:04 EDT 2014
> [INFO] Final Memory: 38M/309M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 26366: Admin : Clean up controllers/ldap API
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26366/#review55535
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Oct. 6, 2014, 12:21 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26366/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2014, 12:21 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-7649
> https://issues.apache.org/jira/browse/AMBARI-7649
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The controllers/ldap API has been replaced with ldap_sync_events. Since the controllers API was never part of a release we should remove it now if it is not needed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ControllerResourceDefinition.java 55e6502
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 2676fd3
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ControllerService.java 6d20a93
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 2fa38c5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ControllerResourceProvider.java afb9ae9
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ControllerType.java 82b6eac
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6cf34ca
> ambari-server/src/main/resources/key_properties.json ef698c5
> ambari-server/src/main/resources/properties.json b99ede5
>
> Diff: https://reviews.apache.org/r/26366/diff/
>
>
> Testing
> -------
>
> All tests pass ...
>
> Results :
>
> Tests run: 2076, Failures: 0, Errors: 0, Skipped: 16
>
> ...
>
>
> [INFO] Executed tasks
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:42.367s
> [INFO] Finished at: Mon Oct 06 11:31:04 EDT 2014
> [INFO] Final Memory: 38M/309M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 26366: Admin : Clean up controllers/ldap API
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26366/#review55510
-----------------------------------------------------------
Ship it!
Hahaha, this is so old there aren't even tests for it!
- Nate Cole
On Oct. 6, 2014, 12:21 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26366/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2014, 12:21 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-7649
> https://issues.apache.org/jira/browse/AMBARI-7649
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The controllers/ldap API has been replaced with ldap_sync_events. Since the controllers API was never part of a release we should remove it now if it is not needed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ControllerResourceDefinition.java 55e6502
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 2676fd3
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ControllerService.java 6d20a93
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 2fa38c5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ControllerResourceProvider.java afb9ae9
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ControllerType.java 82b6eac
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6cf34ca
> ambari-server/src/main/resources/key_properties.json ef698c5
> ambari-server/src/main/resources/properties.json b99ede5
>
> Diff: https://reviews.apache.org/r/26366/diff/
>
>
> Testing
> -------
>
> All tests pass ...
>
> Results :
>
> Tests run: 2076, Failures: 0, Errors: 0, Skipped: 16
>
> ...
>
>
> [INFO] Executed tasks
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:42.367s
> [INFO] Finished at: Mon Oct 06 11:31:04 EDT 2014
> [INFO] Final Memory: 38M/309M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>