[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #3872: Spark : Support parallelism in RemoveOrphanFiles

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #3872:
URL: https://github.com/apache/iceberg/pull/3872#discussion_r784107463



##########
File path: spark/v2.4/spark/src/main/java/org/apache/iceberg/spark/actions/BaseDeleteOrphanFilesSparkAction.java
##########
@@ -85,6 +86,7 @@
       return path.substring(lastIndex + 1);
     }
   }, DataTypes.StringType);
+  private static final ExecutorService DEFAULT_DELETE_EXECUTOR_SERVICE = null;

Review comment:
       nit I would have a new line before this

##########
File path: spark/v2.4/spark/src/main/java/org/apache/iceberg/spark/actions/BaseDeleteOrphanFilesSparkAction.java
##########
@@ -98,6 +100,7 @@ public void accept(String file) {
       table.io().deleteFile(file);
     }
   };
+  private ExecutorService deleteExecutorService = DEFAULT_DELETE_EXECUTOR_SERVICE;

Review comment:
       nit I would have a new line before this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org