You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "neilconway (via GitHub)" <gi...@apache.org> on 2026/09/02 13:35:00 UTC

[PR] chore: Improve `decimal` benchmark coverage [arrow-rs]

neilconway opened a new pull request, #10954:
URL: https://github.com/apache/arrow-rs/pull/10954

   # Which issue does this PR close?
   
   - N/A; motivated by the performance regression in #10850
   
   # Rationale for this change
   
   `decimal` did not have benchmark coverage for end-to-end CSV or JSON parsing; also, the `parse_decimal` microbenchmark had unrepresentative branch predictor behavior.
   
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   
   * Add benchmark for parsing CSV with a decimal field
   * Add benchmark for parsing JSON with a decimal field
   * Improve the `parse_decimal` microbenchmark to generate a set of random strings to parse, rather than repeatedly parsing the same string. Repeatedly parsing the same string is not representative of real-world workloads; in particular, it gives the branch predictor an artificial boost, which can hide constructs that will poorly poorly in more realistic scenarios due to poor branch prediction.
   
   # Are these changes tested?
   
   Yes.
   
   # Are there any user-facing changes?
   
   No.
   
   # AI usage
   
   Developed with Claude Code, Fable 5.1. I revised and understand the resulting code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore: Improve `decimal` benchmark coverage [arrow-rs]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #10954:
URL: https://github.com/apache/arrow-rs/pull/10954#issuecomment-5513855033

   thanks @neilconway & @Rich-T-kid 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore: Improve `decimal` benchmark coverage [arrow-rs]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #10954:
URL: https://github.com/apache/arrow-rs/pull/10954


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org