You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/10 14:57:31 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #15729: Clean up unnecessary Airflow config in helm chart

kaxil commented on a change in pull request #15729:
URL: https://github.com/apache/airflow/pull/15729#discussion_r629432849



##########
File path: chart/values.yaml
##########
@@ -914,10 +912,6 @@ config:
   elasticsearch:
     json_format: 'True'
     log_id_template: "{dag_id}_{task_id}_{execution_date}_{try_number}"
-  elasticsearch_configs:
-    max_retries: 3
-    timeout: 30
-    retry_timeout: 'True'

Review comment:
       This is valid: 
   
   https://airflow.apache.org/docs/apache-airflow-providers-elasticsearch/stable/logging.html#writing-logs-to-elasticsearch-over-tls
   
   This line: https://github.com/apache/airflow/blob/657384615fafc060f9e2ed925017306705770355/airflow/providers/elasticsearch/log/es_task_handler.py#L76 read all the configs passed to `elasticsearch_configs` and passes them as kwargs to ES client




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org