[jira] [Commented] (FLINK-2633) OptionTypeInfo does not have proper equals and hashCode method

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734067#comment-14734067 ] 

ASF GitHub Bot commented on FLINK-2633:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/1104

    [FLINK-2633] [scala, types] Adds equals and hashCode method to OptionTypeInfo

    Adds equals and hashCode method to OptionTypeInfo. This PR allows to compare types containing an option type.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixOptionTypeInfo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1104
    
----
commit b30fa06a96e5a40be484cdf982aba55f88cf4e31
Author: Till Rohrmann <tr...@apache.org>
Date:   2015-09-07T23:12:09Z

    [FLINK-2633] [scala, types] Adds equals and hashCode method to OptionTypeInfo

----


> OptionTypeInfo does not have proper equals and hashCode method
> --------------------------------------------------------------
>
>                 Key: FLINK-2633
>                 URL: https://issues.apache.org/jira/browse/FLINK-2633
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Till Rohrmann
>
> The {{OptionTypeInfo}} does not have a proper {{equals}} and {{hashCode}} definition. As a consequence, types which contain an option type won't be detected to be equal even though the element type of the option is identical. 
> This can cause problems when you try to union two data sets of type {{DataSet[Option[Int]]}}, for example.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)