You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2017/11/29 22:50:42 UTC
[Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8689
Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
......................................................................
IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
This change converts some callers of Status() to Status::Expected()
in the DataStreamMgr to avoid log spew and unnecessary overhead of
stack tracing.
Change-Id: Ie1f7d16e60f7859d662e87642d0f82e1d74183ad
---
M be/src/runtime/data-stream-mgr.cc
M be/src/runtime/krpc-data-stream-mgr.cc
2 files changed, 19 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/8689/1
--
To view, visit http://gerrit.cloudera.org:8080/8689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1f7d16e60f7859d662e87642d0f82e1d74183ad
Gerrit-Change-Number: 8689
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 )
Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc
File be/src/runtime/krpc-data-stream-mgr.cc:
http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc@201
PS1, Line 201: ErrorMsg msg(TErrorCode::DATASTREAM_RECVR_CLOSED, PrintId(finst_id), dest_node_id);
> why doesn't the same argument hold in the non-krpc case. (I don't feel too
We didn't feed this error code back to the sender in the non-krpc case yet. Don't think we do anything for IMPALA-3990 in the non-krpc case.
--
To view, visit http://gerrit.cloudera.org:8080/8689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f7d16e60f7859d662e87642d0f82e1d74183ad
Gerrit-Change-Number: 8689
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Nov 2017 19:57:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 )
Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/data-stream-mgr.cc
File be/src/runtime/data-stream-mgr.cc:
http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/data-stream-mgr.cc@273
PS1, Line 273: return Status(err.str());
> Is this one useful?
This is very unlikely to occur even under load. This is more likely due to a logical error in the code IMHO so I leave it as Status for now.
http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc
File be/src/runtime/krpc-data-stream-mgr.cc:
http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc@201
PS1, Line 201: ErrorMsg msg(TErrorCode::DATASTREAM_RECVR_CLOSED, PrintId(finst_id), dest_node_id);
> Should we log the msg.msg()?
Not really as this doesn't provide much information. We need to propagate an error status to the sender to alleviate the issue described in IMPALA-3990.
http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc@309
PS1, Line 309: return Status(msg);
> same.
This is very unlikely to occur even under load. This is more likely due to a logical error in the code IMHO so I leave it as Status for now.
--
To view, visit http://gerrit.cloudera.org:8080/8689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f7d16e60f7859d662e87642d0f82e1d74183ad
Gerrit-Change-Number: 8689
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Nov 2017 23:19:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 )
Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc
File be/src/runtime/krpc-data-stream-mgr.cc:
http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc@201
PS1, Line 201: ErrorMsg msg(TErrorCode::DATASTREAM_RECVR_CLOSED, PrintId(finst_id), dest_node_id);
> Not really as this doesn't provide much information. We need to propagate a
why doesn't the same argument hold in the non-krpc case. (I don't feel too strongly so okay to leave it alone but curious).
--
To view, visit http://gerrit.cloudera.org:8080/8689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f7d16e60f7859d662e87642d0f82e1d74183ad
Gerrit-Change-Number: 8689
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Nov 2017 18:42:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 )
Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f7d16e60f7859d662e87642d0f82e1d74183ad
Gerrit-Change-Number: 8689
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Nov 2017 23:34:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 )
Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/data-stream-mgr.cc
File be/src/runtime/data-stream-mgr.cc:
http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/data-stream-mgr.cc@273
PS1, Line 273: return Status(err.str());
Is this one useful?
http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc
File be/src/runtime/krpc-data-stream-mgr.cc:
http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc@201
PS1, Line 201: ErrorMsg msg(TErrorCode::DATASTREAM_RECVR_CLOSED, PrintId(finst_id), dest_node_id);
Should we log the msg.msg()?
http://gerrit.cloudera.org:8080/#/c/8689/1/be/src/runtime/krpc-data-stream-mgr.cc@309
PS1, Line 309: return Status(msg);
same.
--
To view, visit http://gerrit.cloudera.org:8080/8689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f7d16e60f7859d662e87642d0f82e1d74183ad
Gerrit-Change-Number: 8689
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Nov 2017 23:06:00 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 )
Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/8689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f7d16e60f7859d662e87642d0f82e1d74183ad
Gerrit-Change-Number: 8689
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Nov 2017 23:25:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8689 )
Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
......................................................................
IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
This change converts some callers of Status() to Status::Expected()
in the DataStreamMgr to avoid log spew and unnecessary overhead of
stack tracing.
Change-Id: Ie1f7d16e60f7859d662e87642d0f82e1d74183ad
Reviewed-on: http://gerrit.cloudera.org:8080/8689
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/data-stream-mgr.cc
M be/src/runtime/krpc-data-stream-mgr.cc
2 files changed, 19 insertions(+), 11 deletions(-)
Approvals:
Bharath Vissapragada: Looks good to me, but someone else must approve
Dan Hecht: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1f7d16e60f7859d662e87642d0f82e1d74183ad
Gerrit-Change-Number: 8689
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 )
Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1549/
--
To view, visit http://gerrit.cloudera.org:8080/8689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f7d16e60f7859d662e87642d0f82e1d74183ad
Gerrit-Change-Number: 8689
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Nov 2017 19:58:47 +0000
Gerrit-HasComments: No