You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4net-dev@logging.apache.org by JJoe2 <gi...@git.apache.org> on 2016/10/15 19:21:32 UTC
[GitHub] log4net pull request #36: Use UTC internally to avoid ambiguous timestamps
GitHub user JJoe2 opened a pull request:
https://github.com/apache/log4net/pull/36
Use UTC internally to avoid ambiguous timestamps
Resubmitting replacement for #24
Rebased to latest trunk and fixed backwards compatibility issue of binary serialization of LoggingEvent.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JJoe2/log4net wip/UseUTC
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/log4net/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit 79a68874f04807f162be7749bd8818120f606be2
Author: JoeJoe <jo...@hotmail.com>
Date: 2016-10-15T19:11:57Z
Use UTC internally to avoid ambiguous timestamps
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net pull request #36: Use UTC internally to avoid ambiguous timestamps
Posted by JJoe2 <gi...@git.apache.org>.
Github user JJoe2 closed the pull request at:
https://github.com/apache/log4net/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net pull request #36: Use UTC internally to avoid ambiguous timestamps
Posted by JJoe2 <gi...@git.apache.org>.
GitHub user JJoe2 reopened a pull request:
https://github.com/apache/log4net/pull/36
Use UTC internally to avoid ambiguous timestamps
Resubmitting replacement for #24
Rebased to latest trunk and fixed backwards compatibility issue of binary serialization of LoggingEvent.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JJoe2/log4net wip/UseUTC
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/log4net/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit c9513671c62ba22609fd7009f1ef60e0b89bffa5
Author: JoeJoe <jo...@hotmail.com>
Date: 2016-10-30T10:13:09Z
Cherry-pick UTC changes
commit 5caefe51d999d4ae34bf887c323e27bfdaee7235
Author: JoeJoe <jo...@hotmail.com>
Date: 2016-10-30T10:49:32Z
Changed LoggingEvent.TimeStamp from a property back to a field to avoid breaking change.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #36: Use UTC internally to avoid ambiguous timestamps
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/log4net/pull/36
I've created LOG4NET-530 so it becomes easier to create the release notes by looking in one place only.
Many thanks, @JJoe2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net pull request #36: Use UTC internally to avoid ambiguous timestamps
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/log4net/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #36: Use UTC internally to avoid ambiguous timestamps
Posted by JJoe2 <gi...@git.apache.org>.
Github user JJoe2 commented on the issue:
https://github.com/apache/log4net/pull/36
Reopened - fixed breaking change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #36: Use UTC internally to avoid ambiguous timestamps
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/log4net/pull/36
@JJoe2 I'm not sure whether you're subscribed to the dev list, you better should be.
Dominik Psenner raised a few questions about different options, see https://lists.apache.org/thread.html/4d354e8ec17a40bb768cc8691289ac78046449e4148f18256f7a110e@%3Clog4net-dev.logging.apache.org%3E and a follow up email.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #36: Use UTC internally to avoid ambiguous timestamps
Posted by JJoe2 <gi...@git.apache.org>.
Github user JJoe2 commented on the issue:
https://github.com/apache/log4net/pull/36
Closing for now - in its current form it's a breaking change - it changes LoggingEvent.DateTime from a field to a property.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---