You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Emmanuel Hugonnet <eh...@redhat.com> on 2020/06/02 09:56:24 UTC
Re: Building on Java 11
Hello,
I' ve updated my branch and rebased on current master from clebert's branch.
It passes a simple build on java 11.0.6
Cheers,
Emmanuel
Le 08/05/2020 à 19:47, Clebert Suconic a écrit :
> Oh wow.. that's awesome.
>
>
> Can we do the migration after the 2.13.0 release? I have pretty much
> everything ready to go (besides a few changes we have to make next
> week). doing this migration now would probably delay the release.
>
>
> Or you have some requirement for Wildfly that you must do this now? if
> you do we can eventually delay it.. but I would prefer doing it for
> later.
>
> On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
>> Hello,
>>
>> When i need to work on Apache ActiveMQ Artemis I need to switch my local environement to use OpenJDK 8 instead of the default OpenJDK 11
>> which I use to develop.
>>
>> I have started a branch https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds on OpenJDK 8 and 11 with the fast-tests profile.
>>
>> mvn clean install -Pfast-tests is passing for me locally :)
>>
>> I don't think that the CI or the release should use Java 11 but I hope this will smoothen the time when the migration occurs.
>>
>> Also I couldn't use the --release 8 flag for OpenJDK 11 because of the use of Unsafe, if someone has a better alternative I'm all hears.
>>
>> Do you want me to sumbit a PR for this ? Does this make sense to the community ?
>>
>> Emmanuel
>>
>>
>>
>
Re: Building on Java 11
Posted by Robbie Gemmell <ro...@gmail.com>.
Emmanuel suggested this:
https://stackoverflow.com/questions/53055564/unable-to-compile-in-intellij-errorjava-exporting-a-package-from-system-modu?noredirect=1&lq=1
Which would seem to line up with your error below. Per the PR [1] the
maven build specifically isn't using the --release flag as although it
would be nice to do so, it wont work because it only permits using the
core public APIs from the target release and not things like Unsafe
etc.
[1] https://github.com/apache/activemq-artemis/pull/3179
On Mon, 15 Jun 2020 at 17:53, Clebert Suconic <cl...@gmail.com> wrote:
>
> I can't open the project on Idea. It says something weird as:
>
> "Error: java: exporting a package from system module jdk.unsupported
> is not allowed with --release"
>
> (mind I had to retype it.. as i can't copy and paste from the error screen)
>
>
> Does anyone know how to get past this?
>
> On Fri, Jun 5, 2020 at 11:38 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> >
> > Thanks
> >
> >
> > Le 05/06/2020 à 16:51, Robbie Gemmell a écrit :
> > > Building the javadoc wouldnt work for me on OpenJDK 11, probably for
> > > the reasons I covered at
> > > https://github.com/apache/activemq-artemis/pull/3161#issuecomment-638789127
> > >
> > > I have since prepared fixes for all the errors however to now get it
> > > to do so. They build on Emmanuel's changes a little so I wont raise a
> > > PR until those are in:
> > > https://github.com/gemmellr/activemq-artemis/tree/java11_javadoc
> > >
> > > On Wed, 3 Jun 2020 at 19:57, Clebert Suconic <cl...@gmail.com> wrote:
> > >> I am able to build with adoptopenjdk 11, but not with 13. a lot of
> > >> errors on javadoc.
> > >>
> > >> We would need to fix those to be able to be flexible enough? or is
> > >> there any magic settings perhaps to relax this?
> > >>
> > >> On Wed, Jun 3, 2020 at 6:16 AM Robbie Gemmell <ro...@gmail.com> wrote:
> > >>> Going back to the error-prone dep being added to all the modules, if
> > >>> those need to stay I think it would be good for the scope+optional
> > >>> elements be added as well? I see its being governed in the
> > >>> dependencyManagement addition, but the various modules appear to have
> > >>> those elements for their existing dependency entries (e.g see the
> > >>> immediate diff context for almost all the additions) so its a bit
> > >>> inconsistent to omit them here.
> > >>>
> > >>> On Tue, 2 Jun 2020 at 18:23, Clebert Suconic <cl...@gmail.com> wrote:
> > >>>> that's cool....
> > >>>>
> > >>>> we should move forward then!
> > >>>>
> > >>>> On Tue, Jun 2, 2020 at 1:19 PM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > >>>>> error-prone 2.4.0 has been released with JDK 14 and 15 support.
> > >>>>>
> > >>>>> This might answer your question :)
> > >>>>>
> > >>>>> Emmanuel
> > >>>>>
> > >>>>> Le 02/06/2020 à 18:31, Clebert Suconic a écrit :
> > >>>>>> But I think it should be on anything 11+
> > >>>>>>
> > >>>>>> I would rather avoid having to re-address this again in the future,
> > >>>>>> and be generic enough.
> > >>>>>>
> > >>>>>>
> > >>>>>> What's holding the build on JDK 13? is it error prone for sure or
> > >>>>>> something else?
> > >>>>>>
> > >>>>>> On Tue, Jun 2, 2020 at 5:56 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > >>>>>>> Hello,
> > >>>>>>>
> > >>>>>>> I' ve updated my branch and rebased on current master from clebert's branch.
> > >>>>>>>
> > >>>>>>> It passes a simple build on java 11.0.6
> > >>>>>>>
> > >>>>>>> Cheers,
> > >>>>>>>
> > >>>>>>> Emmanuel
> > >>>>>>>
> > >>>>>>> Le 08/05/2020 à 19:47, Clebert Suconic a écrit :
> > >>>>>>>> Oh wow.. that's awesome.
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>> Can we do the migration after the 2.13.0 release? I have pretty much
> > >>>>>>>> everything ready to go (besides a few changes we have to make next
> > >>>>>>>> week). doing this migration now would probably delay the release.
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>> Or you have some requirement for Wildfly that you must do this now? if
> > >>>>>>>> you do we can eventually delay it.. but I would prefer doing it for
> > >>>>>>>> later.
> > >>>>>>>>
> > >>>>>>>> On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > >>>>>>>>> Hello,
> > >>>>>>>>>
> > >>>>>>>>> When i need to work on Apache ActiveMQ Artemis I need to switch my local environement to use OpenJDK 8 instead of the default OpenJDK 11
> > >>>>>>>>> which I use to develop.
> > >>>>>>>>>
> > >>>>>>>>> I have started a branch https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds on OpenJDK 8 and 11 with the fast-tests profile.
> > >>>>>>>>>
> > >>>>>>>>> mvn clean install -Pfast-tests is passing for me locally :)
> > >>>>>>>>>
> > >>>>>>>>> I don't think that the CI or the release should use Java 11 but I hope this will smoothen the time when the migration occurs.
> > >>>>>>>>>
> > >>>>>>>>> Also I couldn't use the --release 8 flag for OpenJDK 11 because of the use of Unsafe, if someone has a better alternative I'm all hears.
> > >>>>>>>>>
> > >>>>>>>>> Do you want me to sumbit a PR for this ? Does this make sense to the community ?
> > >>>>>>>>>
> > >>>>>>>>> Emmanuel
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>
> > >>>> --
> > >>>> Clebert Suconic
> > >>
> > >>
> > >> --
> > >> Clebert Suconic
> >
>
>
> --
> Clebert Suconic
Re: Building on Java 11
Posted by Clebert Suconic <cl...@gmail.com>.
I can't open the project on Idea. It says something weird as:
"Error: java: exporting a package from system module jdk.unsupported
is not allowed with --release"
(mind I had to retype it.. as i can't copy and paste from the error screen)
Does anyone know how to get past this?
On Fri, Jun 5, 2020 at 11:38 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
>
> Thanks
>
>
> Le 05/06/2020 à 16:51, Robbie Gemmell a écrit :
> > Building the javadoc wouldnt work for me on OpenJDK 11, probably for
> > the reasons I covered at
> > https://github.com/apache/activemq-artemis/pull/3161#issuecomment-638789127
> >
> > I have since prepared fixes for all the errors however to now get it
> > to do so. They build on Emmanuel's changes a little so I wont raise a
> > PR until those are in:
> > https://github.com/gemmellr/activemq-artemis/tree/java11_javadoc
> >
> > On Wed, 3 Jun 2020 at 19:57, Clebert Suconic <cl...@gmail.com> wrote:
> >> I am able to build with adoptopenjdk 11, but not with 13. a lot of
> >> errors on javadoc.
> >>
> >> We would need to fix those to be able to be flexible enough? or is
> >> there any magic settings perhaps to relax this?
> >>
> >> On Wed, Jun 3, 2020 at 6:16 AM Robbie Gemmell <ro...@gmail.com> wrote:
> >>> Going back to the error-prone dep being added to all the modules, if
> >>> those need to stay I think it would be good for the scope+optional
> >>> elements be added as well? I see its being governed in the
> >>> dependencyManagement addition, but the various modules appear to have
> >>> those elements for their existing dependency entries (e.g see the
> >>> immediate diff context for almost all the additions) so its a bit
> >>> inconsistent to omit them here.
> >>>
> >>> On Tue, 2 Jun 2020 at 18:23, Clebert Suconic <cl...@gmail.com> wrote:
> >>>> that's cool....
> >>>>
> >>>> we should move forward then!
> >>>>
> >>>> On Tue, Jun 2, 2020 at 1:19 PM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> >>>>> error-prone 2.4.0 has been released with JDK 14 and 15 support.
> >>>>>
> >>>>> This might answer your question :)
> >>>>>
> >>>>> Emmanuel
> >>>>>
> >>>>> Le 02/06/2020 à 18:31, Clebert Suconic a écrit :
> >>>>>> But I think it should be on anything 11+
> >>>>>>
> >>>>>> I would rather avoid having to re-address this again in the future,
> >>>>>> and be generic enough.
> >>>>>>
> >>>>>>
> >>>>>> What's holding the build on JDK 13? is it error prone for sure or
> >>>>>> something else?
> >>>>>>
> >>>>>> On Tue, Jun 2, 2020 at 5:56 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> >>>>>>> Hello,
> >>>>>>>
> >>>>>>> I' ve updated my branch and rebased on current master from clebert's branch.
> >>>>>>>
> >>>>>>> It passes a simple build on java 11.0.6
> >>>>>>>
> >>>>>>> Cheers,
> >>>>>>>
> >>>>>>> Emmanuel
> >>>>>>>
> >>>>>>> Le 08/05/2020 à 19:47, Clebert Suconic a écrit :
> >>>>>>>> Oh wow.. that's awesome.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Can we do the migration after the 2.13.0 release? I have pretty much
> >>>>>>>> everything ready to go (besides a few changes we have to make next
> >>>>>>>> week). doing this migration now would probably delay the release.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Or you have some requirement for Wildfly that you must do this now? if
> >>>>>>>> you do we can eventually delay it.. but I would prefer doing it for
> >>>>>>>> later.
> >>>>>>>>
> >>>>>>>> On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> >>>>>>>>> Hello,
> >>>>>>>>>
> >>>>>>>>> When i need to work on Apache ActiveMQ Artemis I need to switch my local environement to use OpenJDK 8 instead of the default OpenJDK 11
> >>>>>>>>> which I use to develop.
> >>>>>>>>>
> >>>>>>>>> I have started a branch https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds on OpenJDK 8 and 11 with the fast-tests profile.
> >>>>>>>>>
> >>>>>>>>> mvn clean install -Pfast-tests is passing for me locally :)
> >>>>>>>>>
> >>>>>>>>> I don't think that the CI or the release should use Java 11 but I hope this will smoothen the time when the migration occurs.
> >>>>>>>>>
> >>>>>>>>> Also I couldn't use the --release 8 flag for OpenJDK 11 because of the use of Unsafe, if someone has a better alternative I'm all hears.
> >>>>>>>>>
> >>>>>>>>> Do you want me to sumbit a PR for this ? Does this make sense to the community ?
> >>>>>>>>>
> >>>>>>>>> Emmanuel
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>
> >>>> --
> >>>> Clebert Suconic
> >>
> >>
> >> --
> >> Clebert Suconic
>
--
Clebert Suconic
Re: Building on Java 11
Posted by Emmanuel Hugonnet <eh...@redhat.com>.
Thanks
Le 05/06/2020 à 16:51, Robbie Gemmell a écrit :
> Building the javadoc wouldnt work for me on OpenJDK 11, probably for
> the reasons I covered at
> https://github.com/apache/activemq-artemis/pull/3161#issuecomment-638789127
>
> I have since prepared fixes for all the errors however to now get it
> to do so. They build on Emmanuel's changes a little so I wont raise a
> PR until those are in:
> https://github.com/gemmellr/activemq-artemis/tree/java11_javadoc
>
> On Wed, 3 Jun 2020 at 19:57, Clebert Suconic <cl...@gmail.com> wrote:
>> I am able to build with adoptopenjdk 11, but not with 13. a lot of
>> errors on javadoc.
>>
>> We would need to fix those to be able to be flexible enough? or is
>> there any magic settings perhaps to relax this?
>>
>> On Wed, Jun 3, 2020 at 6:16 AM Robbie Gemmell <ro...@gmail.com> wrote:
>>> Going back to the error-prone dep being added to all the modules, if
>>> those need to stay I think it would be good for the scope+optional
>>> elements be added as well? I see its being governed in the
>>> dependencyManagement addition, but the various modules appear to have
>>> those elements for their existing dependency entries (e.g see the
>>> immediate diff context for almost all the additions) so its a bit
>>> inconsistent to omit them here.
>>>
>>> On Tue, 2 Jun 2020 at 18:23, Clebert Suconic <cl...@gmail.com> wrote:
>>>> that's cool....
>>>>
>>>> we should move forward then!
>>>>
>>>> On Tue, Jun 2, 2020 at 1:19 PM Emmanuel Hugonnet <eh...@redhat.com> wrote:
>>>>> error-prone 2.4.0 has been released with JDK 14 and 15 support.
>>>>>
>>>>> This might answer your question :)
>>>>>
>>>>> Emmanuel
>>>>>
>>>>> Le 02/06/2020 à 18:31, Clebert Suconic a écrit :
>>>>>> But I think it should be on anything 11+
>>>>>>
>>>>>> I would rather avoid having to re-address this again in the future,
>>>>>> and be generic enough.
>>>>>>
>>>>>>
>>>>>> What's holding the build on JDK 13? is it error prone for sure or
>>>>>> something else?
>>>>>>
>>>>>> On Tue, Jun 2, 2020 at 5:56 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
>>>>>>> Hello,
>>>>>>>
>>>>>>> I' ve updated my branch and rebased on current master from clebert's branch.
>>>>>>>
>>>>>>> It passes a simple build on java 11.0.6
>>>>>>>
>>>>>>> Cheers,
>>>>>>>
>>>>>>> Emmanuel
>>>>>>>
>>>>>>> Le 08/05/2020 à 19:47, Clebert Suconic a écrit :
>>>>>>>> Oh wow.. that's awesome.
>>>>>>>>
>>>>>>>>
>>>>>>>> Can we do the migration after the 2.13.0 release? I have pretty much
>>>>>>>> everything ready to go (besides a few changes we have to make next
>>>>>>>> week). doing this migration now would probably delay the release.
>>>>>>>>
>>>>>>>>
>>>>>>>> Or you have some requirement for Wildfly that you must do this now? if
>>>>>>>> you do we can eventually delay it.. but I would prefer doing it for
>>>>>>>> later.
>>>>>>>>
>>>>>>>> On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
>>>>>>>>> Hello,
>>>>>>>>>
>>>>>>>>> When i need to work on Apache ActiveMQ Artemis I need to switch my local environement to use OpenJDK 8 instead of the default OpenJDK 11
>>>>>>>>> which I use to develop.
>>>>>>>>>
>>>>>>>>> I have started a branch https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds on OpenJDK 8 and 11 with the fast-tests profile.
>>>>>>>>>
>>>>>>>>> mvn clean install -Pfast-tests is passing for me locally :)
>>>>>>>>>
>>>>>>>>> I don't think that the CI or the release should use Java 11 but I hope this will smoothen the time when the migration occurs.
>>>>>>>>>
>>>>>>>>> Also I couldn't use the --release 8 flag for OpenJDK 11 because of the use of Unsafe, if someone has a better alternative I'm all hears.
>>>>>>>>>
>>>>>>>>> Do you want me to sumbit a PR for this ? Does this make sense to the community ?
>>>>>>>>>
>>>>>>>>> Emmanuel
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>
>>>> --
>>>> Clebert Suconic
>>
>>
>> --
>> Clebert Suconic
Re: Building on Java 11
Posted by Robbie Gemmell <ro...@gmail.com>.
Building the javadoc wouldnt work for me on OpenJDK 11, probably for
the reasons I covered at
https://github.com/apache/activemq-artemis/pull/3161#issuecomment-638789127
I have since prepared fixes for all the errors however to now get it
to do so. They build on Emmanuel's changes a little so I wont raise a
PR until those are in:
https://github.com/gemmellr/activemq-artemis/tree/java11_javadoc
On Wed, 3 Jun 2020 at 19:57, Clebert Suconic <cl...@gmail.com> wrote:
>
> I am able to build with adoptopenjdk 11, but not with 13. a lot of
> errors on javadoc.
>
> We would need to fix those to be able to be flexible enough? or is
> there any magic settings perhaps to relax this?
>
> On Wed, Jun 3, 2020 at 6:16 AM Robbie Gemmell <ro...@gmail.com> wrote:
> >
> > Going back to the error-prone dep being added to all the modules, if
> > those need to stay I think it would be good for the scope+optional
> > elements be added as well? I see its being governed in the
> > dependencyManagement addition, but the various modules appear to have
> > those elements for their existing dependency entries (e.g see the
> > immediate diff context for almost all the additions) so its a bit
> > inconsistent to omit them here.
> >
> > On Tue, 2 Jun 2020 at 18:23, Clebert Suconic <cl...@gmail.com> wrote:
> > >
> > > that's cool....
> > >
> > > we should move forward then!
> > >
> > > On Tue, Jun 2, 2020 at 1:19 PM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > > >
> > > > error-prone 2.4.0 has been released with JDK 14 and 15 support.
> > > >
> > > > This might answer your question :)
> > > >
> > > > Emmanuel
> > > >
> > > > Le 02/06/2020 à 18:31, Clebert Suconic a écrit :
> > > > > But I think it should be on anything 11+
> > > > >
> > > > > I would rather avoid having to re-address this again in the future,
> > > > > and be generic enough.
> > > > >
> > > > >
> > > > > What's holding the build on JDK 13? is it error prone for sure or
> > > > > something else?
> > > > >
> > > > > On Tue, Jun 2, 2020 at 5:56 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > > > >> Hello,
> > > > >>
> > > > >> I' ve updated my branch and rebased on current master from clebert's branch.
> > > > >>
> > > > >> It passes a simple build on java 11.0.6
> > > > >>
> > > > >> Cheers,
> > > > >>
> > > > >> Emmanuel
> > > > >>
> > > > >> Le 08/05/2020 à 19:47, Clebert Suconic a écrit :
> > > > >>> Oh wow.. that's awesome.
> > > > >>>
> > > > >>>
> > > > >>> Can we do the migration after the 2.13.0 release? I have pretty much
> > > > >>> everything ready to go (besides a few changes we have to make next
> > > > >>> week). doing this migration now would probably delay the release.
> > > > >>>
> > > > >>>
> > > > >>> Or you have some requirement for Wildfly that you must do this now? if
> > > > >>> you do we can eventually delay it.. but I would prefer doing it for
> > > > >>> later.
> > > > >>>
> > > > >>> On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > > > >>>> Hello,
> > > > >>>>
> > > > >>>> When i need to work on Apache ActiveMQ Artemis I need to switch my local environement to use OpenJDK 8 instead of the default OpenJDK 11
> > > > >>>> which I use to develop.
> > > > >>>>
> > > > >>>> I have started a branch https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds on OpenJDK 8 and 11 with the fast-tests profile.
> > > > >>>>
> > > > >>>> mvn clean install -Pfast-tests is passing for me locally :)
> > > > >>>>
> > > > >>>> I don't think that the CI or the release should use Java 11 but I hope this will smoothen the time when the migration occurs.
> > > > >>>>
> > > > >>>> Also I couldn't use the --release 8 flag for OpenJDK 11 because of the use of Unsafe, if someone has a better alternative I'm all hears.
> > > > >>>>
> > > > >>>> Do you want me to sumbit a PR for this ? Does this make sense to the community ?
> > > > >>>>
> > > > >>>> Emmanuel
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >
> > > >
> > >
> > >
> > > --
> > > Clebert Suconic
>
>
>
> --
> Clebert Suconic
Re: Building on Java 11
Posted by Clebert Suconic <cl...@gmail.com>.
what's nice about this, is that even compatibility tests are
running... (think about that the compatibility tests is mixing a mesh
that includes even old hornetq clients against artemis master, and
these were built with older JDK).
I was afraid old versions of netty woudln't be compatible on the
newest JDK breaking compatibility tests on these old versions. and
that did not happen when I just tested.
On Wed, Jun 3, 2020 at 2:56 PM Clebert Suconic
<cl...@gmail.com> wrote:
>
> I am able to build with adoptopenjdk 11, but not with 13. a lot of
> errors on javadoc.
>
> We would need to fix those to be able to be flexible enough? or is
> there any magic settings perhaps to relax this?
>
> On Wed, Jun 3, 2020 at 6:16 AM Robbie Gemmell <ro...@gmail.com> wrote:
> >
> > Going back to the error-prone dep being added to all the modules, if
> > those need to stay I think it would be good for the scope+optional
> > elements be added as well? I see its being governed in the
> > dependencyManagement addition, but the various modules appear to have
> > those elements for their existing dependency entries (e.g see the
> > immediate diff context for almost all the additions) so its a bit
> > inconsistent to omit them here.
> >
> > On Tue, 2 Jun 2020 at 18:23, Clebert Suconic <cl...@gmail.com> wrote:
> > >
> > > that's cool....
> > >
> > > we should move forward then!
> > >
> > > On Tue, Jun 2, 2020 at 1:19 PM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > > >
> > > > error-prone 2.4.0 has been released with JDK 14 and 15 support.
> > > >
> > > > This might answer your question :)
> > > >
> > > > Emmanuel
> > > >
> > > > Le 02/06/2020 à 18:31, Clebert Suconic a écrit :
> > > > > But I think it should be on anything 11+
> > > > >
> > > > > I would rather avoid having to re-address this again in the future,
> > > > > and be generic enough.
> > > > >
> > > > >
> > > > > What's holding the build on JDK 13? is it error prone for sure or
> > > > > something else?
> > > > >
> > > > > On Tue, Jun 2, 2020 at 5:56 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > > > >> Hello,
> > > > >>
> > > > >> I' ve updated my branch and rebased on current master from clebert's branch.
> > > > >>
> > > > >> It passes a simple build on java 11.0.6
> > > > >>
> > > > >> Cheers,
> > > > >>
> > > > >> Emmanuel
> > > > >>
> > > > >> Le 08/05/2020 à 19:47, Clebert Suconic a écrit :
> > > > >>> Oh wow.. that's awesome.
> > > > >>>
> > > > >>>
> > > > >>> Can we do the migration after the 2.13.0 release? I have pretty much
> > > > >>> everything ready to go (besides a few changes we have to make next
> > > > >>> week). doing this migration now would probably delay the release.
> > > > >>>
> > > > >>>
> > > > >>> Or you have some requirement for Wildfly that you must do this now? if
> > > > >>> you do we can eventually delay it.. but I would prefer doing it for
> > > > >>> later.
> > > > >>>
> > > > >>> On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > > > >>>> Hello,
> > > > >>>>
> > > > >>>> When i need to work on Apache ActiveMQ Artemis I need to switch my local environement to use OpenJDK 8 instead of the default OpenJDK 11
> > > > >>>> which I use to develop.
> > > > >>>>
> > > > >>>> I have started a branch https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds on OpenJDK 8 and 11 with the fast-tests profile.
> > > > >>>>
> > > > >>>> mvn clean install -Pfast-tests is passing for me locally :)
> > > > >>>>
> > > > >>>> I don't think that the CI or the release should use Java 11 but I hope this will smoothen the time when the migration occurs.
> > > > >>>>
> > > > >>>> Also I couldn't use the --release 8 flag for OpenJDK 11 because of the use of Unsafe, if someone has a better alternative I'm all hears.
> > > > >>>>
> > > > >>>> Do you want me to sumbit a PR for this ? Does this make sense to the community ?
> > > > >>>>
> > > > >>>> Emmanuel
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >
> > > >
> > >
> > >
> > > --
> > > Clebert Suconic
>
>
>
> --
> Clebert Suconic
--
Clebert Suconic
Re: Building on Java 11
Posted by Clebert Suconic <cl...@gmail.com>.
I am able to build with adoptopenjdk 11, but not with 13. a lot of
errors on javadoc.
We would need to fix those to be able to be flexible enough? or is
there any magic settings perhaps to relax this?
On Wed, Jun 3, 2020 at 6:16 AM Robbie Gemmell <ro...@gmail.com> wrote:
>
> Going back to the error-prone dep being added to all the modules, if
> those need to stay I think it would be good for the scope+optional
> elements be added as well? I see its being governed in the
> dependencyManagement addition, but the various modules appear to have
> those elements for their existing dependency entries (e.g see the
> immediate diff context for almost all the additions) so its a bit
> inconsistent to omit them here.
>
> On Tue, 2 Jun 2020 at 18:23, Clebert Suconic <cl...@gmail.com> wrote:
> >
> > that's cool....
> >
> > we should move forward then!
> >
> > On Tue, Jun 2, 2020 at 1:19 PM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > >
> > > error-prone 2.4.0 has been released with JDK 14 and 15 support.
> > >
> > > This might answer your question :)
> > >
> > > Emmanuel
> > >
> > > Le 02/06/2020 à 18:31, Clebert Suconic a écrit :
> > > > But I think it should be on anything 11+
> > > >
> > > > I would rather avoid having to re-address this again in the future,
> > > > and be generic enough.
> > > >
> > > >
> > > > What's holding the build on JDK 13? is it error prone for sure or
> > > > something else?
> > > >
> > > > On Tue, Jun 2, 2020 at 5:56 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > > >> Hello,
> > > >>
> > > >> I' ve updated my branch and rebased on current master from clebert's branch.
> > > >>
> > > >> It passes a simple build on java 11.0.6
> > > >>
> > > >> Cheers,
> > > >>
> > > >> Emmanuel
> > > >>
> > > >> Le 08/05/2020 à 19:47, Clebert Suconic a écrit :
> > > >>> Oh wow.. that's awesome.
> > > >>>
> > > >>>
> > > >>> Can we do the migration after the 2.13.0 release? I have pretty much
> > > >>> everything ready to go (besides a few changes we have to make next
> > > >>> week). doing this migration now would probably delay the release.
> > > >>>
> > > >>>
> > > >>> Or you have some requirement for Wildfly that you must do this now? if
> > > >>> you do we can eventually delay it.. but I would prefer doing it for
> > > >>> later.
> > > >>>
> > > >>> On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > > >>>> Hello,
> > > >>>>
> > > >>>> When i need to work on Apache ActiveMQ Artemis I need to switch my local environement to use OpenJDK 8 instead of the default OpenJDK 11
> > > >>>> which I use to develop.
> > > >>>>
> > > >>>> I have started a branch https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds on OpenJDK 8 and 11 with the fast-tests profile.
> > > >>>>
> > > >>>> mvn clean install -Pfast-tests is passing for me locally :)
> > > >>>>
> > > >>>> I don't think that the CI or the release should use Java 11 but I hope this will smoothen the time when the migration occurs.
> > > >>>>
> > > >>>> Also I couldn't use the --release 8 flag for OpenJDK 11 because of the use of Unsafe, if someone has a better alternative I'm all hears.
> > > >>>>
> > > >>>> Do you want me to sumbit a PR for this ? Does this make sense to the community ?
> > > >>>>
> > > >>>> Emmanuel
> > > >>>>
> > > >>>>
> > > >>>>
> > > >
> > >
> >
> >
> > --
> > Clebert Suconic
--
Clebert Suconic
Re: Building on Java 11
Posted by Robbie Gemmell <ro...@gmail.com>.
Going back to the error-prone dep being added to all the modules, if
those need to stay I think it would be good for the scope+optional
elements be added as well? I see its being governed in the
dependencyManagement addition, but the various modules appear to have
those elements for their existing dependency entries (e.g see the
immediate diff context for almost all the additions) so its a bit
inconsistent to omit them here.
On Tue, 2 Jun 2020 at 18:23, Clebert Suconic <cl...@gmail.com> wrote:
>
> that's cool....
>
> we should move forward then!
>
> On Tue, Jun 2, 2020 at 1:19 PM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> >
> > error-prone 2.4.0 has been released with JDK 14 and 15 support.
> >
> > This might answer your question :)
> >
> > Emmanuel
> >
> > Le 02/06/2020 à 18:31, Clebert Suconic a écrit :
> > > But I think it should be on anything 11+
> > >
> > > I would rather avoid having to re-address this again in the future,
> > > and be generic enough.
> > >
> > >
> > > What's holding the build on JDK 13? is it error prone for sure or
> > > something else?
> > >
> > > On Tue, Jun 2, 2020 at 5:56 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > >> Hello,
> > >>
> > >> I' ve updated my branch and rebased on current master from clebert's branch.
> > >>
> > >> It passes a simple build on java 11.0.6
> > >>
> > >> Cheers,
> > >>
> > >> Emmanuel
> > >>
> > >> Le 08/05/2020 à 19:47, Clebert Suconic a écrit :
> > >>> Oh wow.. that's awesome.
> > >>>
> > >>>
> > >>> Can we do the migration after the 2.13.0 release? I have pretty much
> > >>> everything ready to go (besides a few changes we have to make next
> > >>> week). doing this migration now would probably delay the release.
> > >>>
> > >>>
> > >>> Or you have some requirement for Wildfly that you must do this now? if
> > >>> you do we can eventually delay it.. but I would prefer doing it for
> > >>> later.
> > >>>
> > >>> On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > >>>> Hello,
> > >>>>
> > >>>> When i need to work on Apache ActiveMQ Artemis I need to switch my local environement to use OpenJDK 8 instead of the default OpenJDK 11
> > >>>> which I use to develop.
> > >>>>
> > >>>> I have started a branch https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds on OpenJDK 8 and 11 with the fast-tests profile.
> > >>>>
> > >>>> mvn clean install -Pfast-tests is passing for me locally :)
> > >>>>
> > >>>> I don't think that the CI or the release should use Java 11 but I hope this will smoothen the time when the migration occurs.
> > >>>>
> > >>>> Also I couldn't use the --release 8 flag for OpenJDK 11 because of the use of Unsafe, if someone has a better alternative I'm all hears.
> > >>>>
> > >>>> Do you want me to sumbit a PR for this ? Does this make sense to the community ?
> > >>>>
> > >>>> Emmanuel
> > >>>>
> > >>>>
> > >>>>
> > >
> >
>
>
> --
> Clebert Suconic
Re: Building on Java 11
Posted by Robbie Gemmell <ro...@gmail.com>.
Can I ask again about the seemingly broken errorprone-javac config on
the branch, which looks to be using a non-existent javac.version
property config:
"<arg>-J-Xbootclasspath/p:${settings.localRepository}/com/google/errorprone/javac/${javac.version}/javac-${javac.version}.jar
Looking at https://errorprone.info/docs/installation suggests you do
need to set the property so the jar can be found, matching whatever
dependency the errorprone-core being used is using (which is
presumably what will make the javac jar actually get pulled into the
local repo at all).
It also indicates only doing this config approach on Java 8 because it
doesnt work on 9+, so they have an 8-specific profile for it whilst on
the branch seems to be happening for all versions. Should it be
profiled?
On Tue, 2 Jun 2020 at 18:23, Clebert Suconic <cl...@gmail.com> wrote:
>
> that's cool....
>
> we should move forward then!
>
> On Tue, Jun 2, 2020 at 1:19 PM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> >
> > error-prone 2.4.0 has been released with JDK 14 and 15 support.
> >
> > This might answer your question :)
> >
> > Emmanuel
> >
> > Le 02/06/2020 à 18:31, Clebert Suconic a écrit :
> > > But I think it should be on anything 11+
> > >
> > > I would rather avoid having to re-address this again in the future,
> > > and be generic enough.
> > >
> > >
> > > What's holding the build on JDK 13? is it error prone for sure or
> > > something else?
> > >
> > > On Tue, Jun 2, 2020 at 5:56 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > >> Hello,
> > >>
> > >> I' ve updated my branch and rebased on current master from clebert's branch.
> > >>
> > >> It passes a simple build on java 11.0.6
> > >>
> > >> Cheers,
> > >>
> > >> Emmanuel
> > >>
> > >> Le 08/05/2020 à 19:47, Clebert Suconic a écrit :
> > >>> Oh wow.. that's awesome.
> > >>>
> > >>>
> > >>> Can we do the migration after the 2.13.0 release? I have pretty much
> > >>> everything ready to go (besides a few changes we have to make next
> > >>> week). doing this migration now would probably delay the release.
> > >>>
> > >>>
> > >>> Or you have some requirement for Wildfly that you must do this now? if
> > >>> you do we can eventually delay it.. but I would prefer doing it for
> > >>> later.
> > >>>
> > >>> On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> > >>>> Hello,
> > >>>>
> > >>>> When i need to work on Apache ActiveMQ Artemis I need to switch my local environement to use OpenJDK 8 instead of the default OpenJDK 11
> > >>>> which I use to develop.
> > >>>>
> > >>>> I have started a branch https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds on OpenJDK 8 and 11 with the fast-tests profile.
> > >>>>
> > >>>> mvn clean install -Pfast-tests is passing for me locally :)
> > >>>>
> > >>>> I don't think that the CI or the release should use Java 11 but I hope this will smoothen the time when the migration occurs.
> > >>>>
> > >>>> Also I couldn't use the --release 8 flag for OpenJDK 11 because of the use of Unsafe, if someone has a better alternative I'm all hears.
> > >>>>
> > >>>> Do you want me to sumbit a PR for this ? Does this make sense to the community ?
> > >>>>
> > >>>> Emmanuel
> > >>>>
> > >>>>
> > >>>>
> > >
> >
>
>
> --
> Clebert Suconic
Re: Building on Java 11
Posted by "michael.andre.pearce" <mi...@me.com.INVALID>.
As long as it still builds and releases on 8 sounds good.8 has almost the same lifespan as 11 and anything else is not lts. Most users will want to be running on supported lts versions with many still being 8.Sent from my Samsung Galaxy smartphone.
-------- Original message --------From: Clebert Suconic <cl...@gmail.com> Date: 02/06/2020 18:23 (GMT+00:00) To: Emmanuel Hugonnet <eh...@redhat.com> Cc: dev@activemq.apache.org Subject: Re: Building on Java 11 that's cool....we should move forward then!On Tue, Jun 2, 2020 at 1:19 PM Emmanuel Hugonnet <eh...@redhat.com> wrote:>> error-prone 2.4.0 has been released with JDK 14 and 15 support.>> This might answer your question :)>> Emmanuel>> Le 02/06/2020 à 18:31, Clebert Suconic a écrit :> > But I think it should be on anything 11+> >> > I would rather avoid having to re-address this again in the future,> > and be generic enough.> >> >> > What's holding the build on JDK 13? is it error prone for sure or> > something else?> >> > On Tue, Jun 2, 2020 at 5:56 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:> >> Hello,> >>> >> I' ve updated my branch and rebased on current master from clebert's branch.> >>> >> It passes a simple build on java 11.0.6> >>> >> Cheers,> >>> >> Emmanuel> >>> >> Le 08/05/2020 à 19:47, Clebert Suconic a écrit :> >>> Oh wow.. that's awesome.> >>>> >>>> >>> Can we do the migration after the 2.13.0 release? I have pretty much> >>> everything ready to go (besides a few changes we have to make next> >>> week). doing this migration now would probably delay the release.> >>>> >>>> >>> Or you have some requirement for Wildfly that you must do this now? if> >>> you do we can eventually delay it.. but I would prefer doing it for> >>> later.> >>>> >>> On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:> >>>> Hello,> >>>>> >>>> When i need to work on Apache ActiveMQ Artemis I need to switch my local environement to use OpenJDK 8 instead of the default OpenJDK 11> >>>> which I use to develop.> >>>>> >>>> I have started a branch https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds on OpenJDK 8 and 11 with the fast-tests profile.> >>>>> >>>> mvn clean install -Pfast-tests is passing for me locally :)> >>>>> >>>> I don't think that the CI or the release should use Java 11 but I hope this will smoothen the time when the migration occurs.> >>>>> >>>> Also I couldn't use the --release 8 flag for OpenJDK 11 because of the use of Unsafe, if someone has a better alternative I'm all hears.> >>>>> >>>> Do you want me to sumbit a PR for this ? Does this make sense to the community ?> >>>>> >>>> Emmanuel> >>>>> >>>>> >>>>> >>-- Clebert Suconic
Re: Building on Java 11
Posted by Clebert Suconic <cl...@gmail.com>.
that's cool....
we should move forward then!
On Tue, Jun 2, 2020 at 1:19 PM Emmanuel Hugonnet <eh...@redhat.com> wrote:
>
> error-prone 2.4.0 has been released with JDK 14 and 15 support.
>
> This might answer your question :)
>
> Emmanuel
>
> Le 02/06/2020 à 18:31, Clebert Suconic a écrit :
> > But I think it should be on anything 11+
> >
> > I would rather avoid having to re-address this again in the future,
> > and be generic enough.
> >
> >
> > What's holding the build on JDK 13? is it error prone for sure or
> > something else?
> >
> > On Tue, Jun 2, 2020 at 5:56 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> >> Hello,
> >>
> >> I' ve updated my branch and rebased on current master from clebert's branch.
> >>
> >> It passes a simple build on java 11.0.6
> >>
> >> Cheers,
> >>
> >> Emmanuel
> >>
> >> Le 08/05/2020 à 19:47, Clebert Suconic a écrit :
> >>> Oh wow.. that's awesome.
> >>>
> >>>
> >>> Can we do the migration after the 2.13.0 release? I have pretty much
> >>> everything ready to go (besides a few changes we have to make next
> >>> week). doing this migration now would probably delay the release.
> >>>
> >>>
> >>> Or you have some requirement for Wildfly that you must do this now? if
> >>> you do we can eventually delay it.. but I would prefer doing it for
> >>> later.
> >>>
> >>> On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> >>>> Hello,
> >>>>
> >>>> When i need to work on Apache ActiveMQ Artemis I need to switch my local environement to use OpenJDK 8 instead of the default OpenJDK 11
> >>>> which I use to develop.
> >>>>
> >>>> I have started a branch https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds on OpenJDK 8 and 11 with the fast-tests profile.
> >>>>
> >>>> mvn clean install -Pfast-tests is passing for me locally :)
> >>>>
> >>>> I don't think that the CI or the release should use Java 11 but I hope this will smoothen the time when the migration occurs.
> >>>>
> >>>> Also I couldn't use the --release 8 flag for OpenJDK 11 because of the use of Unsafe, if someone has a better alternative I'm all hears.
> >>>>
> >>>> Do you want me to sumbit a PR for this ? Does this make sense to the community ?
> >>>>
> >>>> Emmanuel
> >>>>
> >>>>
> >>>>
> >
>
--
Clebert Suconic
Re: Building on Java 11
Posted by Emmanuel Hugonnet <eh...@redhat.com>.
error-prone 2.4.0 has been released with JDK 14 and 15 support.
This might answer your question :)
Emmanuel
Le 02/06/2020 à 18:31, Clebert Suconic a écrit :
> But I think it should be on anything 11+
>
> I would rather avoid having to re-address this again in the future,
> and be generic enough.
>
>
> What's holding the build on JDK 13? is it error prone for sure or
> something else?
>
> On Tue, Jun 2, 2020 at 5:56 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
>> Hello,
>>
>> I' ve updated my branch and rebased on current master from clebert's branch.
>>
>> It passes a simple build on java 11.0.6
>>
>> Cheers,
>>
>> Emmanuel
>>
>> Le 08/05/2020 à 19:47, Clebert Suconic a écrit :
>>> Oh wow.. that's awesome.
>>>
>>>
>>> Can we do the migration after the 2.13.0 release? I have pretty much
>>> everything ready to go (besides a few changes we have to make next
>>> week). doing this migration now would probably delay the release.
>>>
>>>
>>> Or you have some requirement for Wildfly that you must do this now? if
>>> you do we can eventually delay it.. but I would prefer doing it for
>>> later.
>>>
>>> On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
>>>> Hello,
>>>>
>>>> When i need to work on Apache ActiveMQ Artemis I need to switch my local environement to use OpenJDK 8 instead of the default OpenJDK 11
>>>> which I use to develop.
>>>>
>>>> I have started a branch https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds on OpenJDK 8 and 11 with the fast-tests profile.
>>>>
>>>> mvn clean install -Pfast-tests is passing for me locally :)
>>>>
>>>> I don't think that the CI or the release should use Java 11 but I hope this will smoothen the time when the migration occurs.
>>>>
>>>> Also I couldn't use the --release 8 flag for OpenJDK 11 because of the use of Unsafe, if someone has a better alternative I'm all hears.
>>>>
>>>> Do you want me to sumbit a PR for this ? Does this make sense to the community ?
>>>>
>>>> Emmanuel
>>>>
>>>>
>>>>
>
Re: Building on Java 11
Posted by Clebert Suconic <cl...@gmail.com>.
But I think it should be on anything 11+
I would rather avoid having to re-address this again in the future,
and be generic enough.
What's holding the build on JDK 13? is it error prone for sure or
something else?
On Tue, Jun 2, 2020 at 5:56 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
>
> Hello,
>
> I' ve updated my branch and rebased on current master from clebert's branch.
>
> It passes a simple build on java 11.0.6
>
> Cheers,
>
> Emmanuel
>
> Le 08/05/2020 à 19:47, Clebert Suconic a écrit :
> > Oh wow.. that's awesome.
> >
> >
> > Can we do the migration after the 2.13.0 release? I have pretty much
> > everything ready to go (besides a few changes we have to make next
> > week). doing this migration now would probably delay the release.
> >
> >
> > Or you have some requirement for Wildfly that you must do this now? if
> > you do we can eventually delay it.. but I would prefer doing it for
> > later.
> >
> > On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <eh...@redhat.com> wrote:
> >> Hello,
> >>
> >> When i need to work on Apache ActiveMQ Artemis I need to switch my local environement to use OpenJDK 8 instead of the default OpenJDK 11
> >> which I use to develop.
> >>
> >> I have started a branch https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds on OpenJDK 8 and 11 with the fast-tests profile.
> >>
> >> mvn clean install -Pfast-tests is passing for me locally :)
> >>
> >> I don't think that the CI or the release should use Java 11 but I hope this will smoothen the time when the migration occurs.
> >>
> >> Also I couldn't use the --release 8 flag for OpenJDK 11 because of the use of Unsafe, if someone has a better alternative I'm all hears.
> >>
> >> Do you want me to sumbit a PR for this ? Does this make sense to the community ?
> >>
> >> Emmanuel
> >>
> >>
> >>
> >
>
--
Clebert Suconic