You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2018/11/03 00:50:23 UTC
[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11873
Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
......................................................................
IMPALA-7565: Add startup flag to set thrift connection setup thread
pool size
This patch adds a hidden experimental startup flag which enables setting
the size of the thread pool used to process the internal post-accept,
pre-setup connection queue for Impala internal connections.
The default is set to 1 which ensures that this change does not affect
current behaviour.
Testing:
Tested manually by adding a sleep and making sure other threads are
used.
TODO: run exhaustive tests with a pool size > 1.
Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
---
M be/src/rpc/TAcceptQueueServer.cpp
1 file changed, 15 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/11873/1
--
To view, visit http://gerrit.cloudera.org:8080/11873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
Gerrit-Change-Number: 11873
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11873 )
Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1270/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
Gerrit-Change-Number: 11873
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Sat, 03 Nov 2018 01:29:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11873 )
Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
Gerrit-Change-Number: 11873
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Nov 2018 23:31:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11873 )
Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1283/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
Gerrit-Change-Number: 11873
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Nov 2018 23:32:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11873 )
Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11873/1/be/src/rpc/TAcceptQueueServer.cpp
File be/src/rpc/TAcceptQueueServer.cpp:
http://gerrit.cloudera.org:8080/#/c/11873/1/be/src/rpc/TAcceptQueueServer.cpp@30
PS1, Line 30: internal connections
nit: not necessarily Impala internal connections. This class is used for Beeswax and HS2 servers too.
http://gerrit.cloudera.org:8080/#/c/11873/1/be/src/rpc/TAcceptQueueServer.cpp@32
PS1, Line 32: connection
May be "accepted_cnxn_setup_thread_pool_size" so it's consistent with the other knob.
http://gerrit.cloudera.org:8080/#/c/11873/1/be/src/rpc/TAcceptQueueServer.cpp@34
PS1, Line 34: internal connections
nit: not necessarily Impala internal connections. This class is used for Beeswax and HS2 servers too.
--
To view, visit http://gerrit.cloudera.org:8080/11873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
Gerrit-Change-Number: 11873
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Sat, 03 Nov 2018 00:54:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11873 )
Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
Gerrit-Change-Number: 11873
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Nov 2018 03:22:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11873 )
Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11873/1/be/src/rpc/TAcceptQueueServer.cpp
File be/src/rpc/TAcceptQueueServer.cpp:
http://gerrit.cloudera.org:8080/#/c/11873/1/be/src/rpc/TAcceptQueueServer.cpp@30
PS1, Line 30: internal connections
> nit: not necessarily Impala internal connections. This class is used for Be
Done
http://gerrit.cloudera.org:8080/#/c/11873/1/be/src/rpc/TAcceptQueueServer.cpp@32
PS1, Line 32: connection
> May be "accepted_cnxn_setup_thread_pool_size" so it's consistent with the o
Done
http://gerrit.cloudera.org:8080/#/c/11873/1/be/src/rpc/TAcceptQueueServer.cpp@34
PS1, Line 34: internal connections
> nit: not necessarily Impala internal connections. This class is used for Be
Done
--
To view, visit http://gerrit.cloudera.org:8080/11873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
Gerrit-Change-Number: 11873
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Nov 2018 22:50:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11873 )
Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
......................................................................
IMPALA-7565: Add startup flag to set thrift connection setup thread
pool size
This patch adds a hidden experimental startup flag called
'accepted_cnxn_setup_thread_pool_size' which enables setting the size
of the thread pool used to process the internal post-accept, pre-setup
connection queue in each thrift server set up to service
Impala internal and external connections. The default is set to 1
which ensures that this change does not affect current behavior.
Testing:
Tested manually by adding a sleep and making sure other threads are
used.
Ran exhaustive tests with a pool size set to 10 successfully.
Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
Reviewed-on: http://gerrit.cloudera.org:8080/11873
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/rpc/TAcceptQueueServer.cpp
1 file changed, 17 insertions(+), 7 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
Gerrit-Change-Number: 11873
Gerrit-PatchSet: 5
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11873 )
Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Carrying over +2
http://gerrit.cloudera.org:8080/#/c/11873/2/be/src/rpc/TAcceptQueueServer.cpp
File be/src/rpc/TAcceptQueueServer.cpp:
http://gerrit.cloudera.org:8080/#/c/11873/2/be/src/rpc/TAcceptQueueServer.cpp@30
PS2, Line 30: Impala internal and external connections.");
> nit: could be simpler to just say "Impala internal and external connections
Done
http://gerrit.cloudera.org:8080/#/c/11873/2/be/src/rpc/TAcceptQueueServer.cpp@35
PS2, Line 35: internal and external connections. Warning: T
> internal and external
Done
--
To view, visit http://gerrit.cloudera.org:8080/11873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
Gerrit-Change-Number: 11873
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Nov 2018 23:30:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11873 )
Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1286/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
Gerrit-Change-Number: 11873
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Nov 2018 00:02:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11873 )
Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11873/2/be/src/rpc/TAcceptQueueServer.cpp
File be/src/rpc/TAcceptQueueServer.cpp:
http://gerrit.cloudera.org:8080/#/c/11873/2/be/src/rpc/TAcceptQueueServer.cpp@30
PS2, Line 30: Impala internal, Beeswax and HiveServer2 connections
nit: could be simpler to just say "Impala internal and external connections".
http://gerrit.cloudera.org:8080/#/c/11873/2/be/src/rpc/TAcceptQueueServer.cpp@35
PS2, Line 35: internal, Beeswax and HiveServer2 connections
internal and external
--
To view, visit http://gerrit.cloudera.org:8080/11873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
Gerrit-Change-Number: 11873
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Nov 2018 23:12:29 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11873 )
Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3427/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
Gerrit-Change-Number: 11873
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Nov 2018 23:31:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11873
to look at the new patch set (#2).
Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
......................................................................
IMPALA-7565: Add startup flag to set thrift connection setup thread
pool size
This patch adds a hidden experimental startup flag called
'accepted_cnxn_setup_thread_pool_size' which enables setting the size
of the thread pool used to process the internal post-accept, pre-setup
connection queue in each thrift server set up to service
Impala internal, Beeswax and HiveServer2 connections. The default is
set to 1 which ensures that this change does not affect current
behavior.
Testing:
Tested manually by adding a sleep and making sure other threads are
used.
Ran exhaustive tests with a pool size set to 10 successfully.
Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
---
M be/src/rpc/TAcceptQueueServer.cpp
1 file changed, 18 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/11873/2
--
To view, visit http://gerrit.cloudera.org:8080/11873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
Gerrit-Change-Number: 11873
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11873
to look at the new patch set (#3).
Change subject: IMPALA-7565: Add startup flag to set thrift connection setup thread pool size
......................................................................
IMPALA-7565: Add startup flag to set thrift connection setup thread
pool size
This patch adds a hidden experimental startup flag called
'accepted_cnxn_setup_thread_pool_size' which enables setting the size
of the thread pool used to process the internal post-accept, pre-setup
connection queue in each thrift server set up to service
Impala internal and external connections. The default is set to 1
which ensures that this change does not affect current behavior.
Testing:
Tested manually by adding a sleep and making sure other threads are
used.
Ran exhaustive tests with a pool size set to 10 successfully.
Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
---
M be/src/rpc/TAcceptQueueServer.cpp
1 file changed, 17 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/11873/3
--
To view, visit http://gerrit.cloudera.org:8080/11873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I31344321a5f9e840a399ccb0f963c0759e2ab234
Gerrit-Change-Number: 11873
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>