You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:42:16 UTC
[GitHub] [spark] Ngone51 opened a new pull request #28756: [SPARK-8981]
Ngone51 opened a new pull request #28756:
URL: https://github.com/apache/spark/pull/28756
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642663571
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438650463
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -703,11 +709,10 @@ private[spark] class Executor(
}
private def setMDCForTask(taskName: String, mdc: Seq[(String, String)]): Unit = {
- MDC.put("taskName", taskName)
-
Review comment:
can we do `MDC.clear()` at the beginning of this method? It looks safer if we want to make sure we run the task with only the user-specified mdc properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642534353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] igreenfield commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
igreenfield commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438620977
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -969,4 +992,7 @@ private[spark] object Executor {
// task is fully deserialized. When possible, the TaskContext.getLocalProperty call should be
// used instead.
val taskDeserializationProps: ThreadLocal[Properties] = new ThreadLocal[Properties]
+
+ val MDC_KEY = "mdc."
+ val TASK_MDC_KEY = s"${MDC_KEY}taskName"
Review comment:
as I remember before it was just taskName without mdc.taskName
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642521625
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642521625
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438623239
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -969,4 +992,7 @@ private[spark] object Executor {
// task is fully deserialized. When possible, the TaskContext.getLocalProperty call should be
// used instead.
val taskDeserializationProps: ThreadLocal[Properties] = new ThreadLocal[Properties]
+
+ val MDC_KEY = "mdc."
+ val TASK_MDC_KEY = s"${MDC_KEY}taskName"
Review comment:
This is used internally in order to handle taskName consistently with custom MDC properties. It has no effect on users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642685289
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438509140
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -322,11 +322,15 @@ private[spark] class Executor(
val taskId = taskDescription.taskId
val threadName = s"Executor task launch worker for task $taskId"
val taskName = taskDescription.name
- val mdcProperties = taskDescription.properties.asScala
- .filter(_._1.startsWith("mdc.")).map { item =>
+ val mdcProperties = (taskDescription.properties.asScala ++
+ Seq((Executor.TASK_MDC_KEY, taskName)))
+ .filter(_._1.startsWith(Executor.MDC_KEY)).map { item =>
val key = item._1.substring(4)
+ if (key == Executor.TASK_MDC_KEY && item._2 != taskName) {
+ logWarning(s"Override mdc.taskName is not allowed, ignore ${item._2}")
Review comment:
Actually, we've already add the task mdc key at the new line 326. We can remove the warning if it's ok to override silently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28756:
URL: https://github.com/apache/spark/pull/28756
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642532940
**[Test build #123843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123843/testReport)** for PR 28756 at commit [`2f1b86b`](https://github.com/apache/spark/commit/2f1b86b59d92c3a163034e8a478536d1fc13fcac).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642663571
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-640700418
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] igreenfield commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
igreenfield commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438644805
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -322,11 +322,15 @@ private[spark] class Executor(
val taskId = taskDescription.taskId
val threadName = s"Executor task launch worker for task $taskId"
val taskName = taskDescription.name
- val mdcProperties = taskDescription.properties.asScala
- .filter(_._1.startsWith("mdc.")).map { item =>
+ val mdcProperties = (taskDescription.properties.asScala ++
+ Seq((Executor.TASK_MDC_KEY, taskName)))
+ .filter(_._1.startsWith(Executor.MDC_KEY)).map { item =>
val key = item._1.substring(4)
+ if (key == Executor.TASK_MDC_KEY && item._2 != taskName) {
+ logWarning(s"Override mdc.taskName is not allowed, ignore ${item._2}")
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438623239
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -969,4 +992,7 @@ private[spark] object Executor {
// task is fully deserialized. When possible, the TaskContext.getLocalProperty call should be
// used instead.
val taskDeserializationProps: ThreadLocal[Properties] = new ThreadLocal[Properties]
+
+ val MDC_KEY = "mdc."
+ val TASK_MDC_KEY = s"${MDC_KEY}taskName"
Review comment:
This is used internally in order to handle taskName consistently with custom MDC properties. It has no effect to users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642727718
thanks all!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642607548
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] igreenfield commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
igreenfield commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438577011
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -322,11 +322,15 @@ private[spark] class Executor(
val taskId = taskDescription.taskId
val threadName = s"Executor task launch worker for task $taskId"
val taskName = taskDescription.name
- val mdcProperties = taskDescription.properties.asScala
- .filter(_._1.startsWith("mdc.")).map { item =>
+ val mdcProperties = (taskDescription.properties.asScala ++
+ Seq((Executor.TASK_MDC_KEY, taskName)))
+ .filter(_._1.startsWith(Executor.MDC_KEY)).map { item =>
val key = item._1.substring(4)
+ if (key == Executor.TASK_MDC_KEY && item._2 != taskName) {
+ logWarning(s"Override mdc.taskName is not allowed, ignore ${item._2}")
Review comment:
I think we should let the user override it, and write to the log that is overridden.
(windows way is not let you do things, Linux way: with great power comes greater responsibility)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642532940
**[Test build #123843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123843/testReport)** for PR 28756 at commit [`2f1b86b`](https://github.com/apache/spark/commit/2f1b86b59d92c3a163034e8a478536d1fc13fcac).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438575268
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -322,11 +322,15 @@ private[spark] class Executor(
val taskId = taskDescription.taskId
val threadName = s"Executor task launch worker for task $taskId"
val taskName = taskDescription.name
- val mdcProperties = taskDescription.properties.asScala
- .filter(_._1.startsWith("mdc.")).map { item =>
+ val mdcProperties = (taskDescription.properties.asScala ++
+ Seq((Executor.TASK_MDC_KEY, taskName)))
+ .filter(_._1.startsWith(Executor.MDC_KEY)).map { item =>
val key = item._1.substring(4)
+ if (key == Executor.TASK_MDC_KEY && item._2 != taskName) {
+ logWarning(s"Override mdc.taskName is not allowed, ignore ${item._2}")
Review comment:
then our document is wrong. We must make sure `taskName` always represent the value as we documented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438633426
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -969,4 +992,7 @@ private[spark] object Executor {
// task is fully deserialized. When possible, the TaskContext.getLocalProperty call should be
// used instead.
val taskDeserializationProps: ThreadLocal[Properties] = new ThreadLocal[Properties]
+
+ val MDC_KEY = "mdc."
+ val TASK_MDC_KEY = s"${MDC_KEY}taskName"
Review comment:
It affects end-users, as now they need to use `mdc.taskName` in the log4j config file, instead of `taskName`.
But it's not released yet, I'm fine to make it consistent that all the MDC properties start with `mdc.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-640701041
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438141415
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -322,11 +322,15 @@ private[spark] class Executor(
val taskId = taskDescription.taskId
val threadName = s"Executor task launch worker for task $taskId"
val taskName = taskDescription.name
- val mdcProperties = taskDescription.properties.asScala
- .filter(_._1.startsWith("mdc.")).map { item =>
+ val mdcProperties = (taskDescription.properties.asScala ++
+ Seq((Executor.TASK_MDC_KEY, taskName)))
+ .filter(_._1.startsWith(Executor.MDC_KEY)).map { item =>
val key = item._1.substring(4)
+ if (key == Executor.TASK_MDC_KEY && item._2 != taskName) {
+ logWarning(s"Override mdc.taskName is not allowed, ignore ${item._2}")
Review comment:
shall we simply set the task mdc key at the end? then it will not be overwritten.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438584922
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -969,4 +992,7 @@ private[spark] object Executor {
// task is fully deserialized. When possible, the TaskContext.getLocalProperty call should be
// used instead.
val taskDeserializationProps: ThreadLocal[Properties] = new ThreadLocal[Properties]
+
+ val MDC_KEY = "mdc."
+ val TASK_MDC_KEY = s"${MDC_KEY}taskName"
Review comment:
IIUC, the change doesn't introduce any difference to the end-user, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-640701041
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-640700418
**[Test build #123639 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123639/testReport)** for PR 28756 at commit [`be3d752`](https://github.com/apache/spark/commit/be3d7521eb68a9ded5fc4f3cf4b71ca4d1d226be).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438511572
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -401,9 +405,22 @@ private[spark] class Executor(
}
override def run(): Unit = {
+ val oldMdcProperties = mdcProperties.keys.map(k => (k, MDC.get(k)))
Review comment:
I think we can normally, and I'd prefer to clear it inside `finally`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642010206
ping @cloud-fan @igreenfield Please take a look!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642660583
**[Test build #123843 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123843/testReport)** for PR 28756 at commit [`2f1b86b`](https://github.com/apache/spark/commit/2f1b86b59d92c3a163034e8a478536d1fc13fcac).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642520313
**[Test build #123842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123842/testReport)** for PR 28756 at commit [`0cefc61`](https://github.com/apache/spark/commit/0cefc616952a22f3d66d79e793e8efb2e62d009a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438654440
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -703,11 +709,10 @@ private[spark] class Executor(
}
private def setMDCForTask(taskName: String, mdc: Seq[(String, String)]): Unit = {
- MDC.put("taskName", taskName)
-
Review comment:
ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438518655
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -322,11 +322,15 @@ private[spark] class Executor(
val taskId = taskDescription.taskId
val threadName = s"Executor task launch worker for task $taskId"
val taskName = taskDescription.name
- val mdcProperties = taskDescription.properties.asScala
- .filter(_._1.startsWith("mdc.")).map { item =>
+ val mdcProperties = (taskDescription.properties.asScala ++
+ Seq((Executor.TASK_MDC_KEY, taskName)))
+ .filter(_._1.startsWith(Executor.MDC_KEY)).map { item =>
val key = item._1.substring(4)
+ if (key == Executor.TASK_MDC_KEY && item._2 != taskName) {
+ logWarning(s"Override mdc.taskName is not allowed, ignore ${item._2}")
Review comment:
I think the original `setMDCForTask` method looks OK as long as we set task mdc key at the end. It also helps avoid duplicated code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] igreenfield commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
igreenfield commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438570609
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -322,11 +322,15 @@ private[spark] class Executor(
val taskId = taskDescription.taskId
val threadName = s"Executor task launch worker for task $taskId"
val taskName = taskDescription.name
- val mdcProperties = taskDescription.properties.asScala
- .filter(_._1.startsWith("mdc.")).map { item =>
+ val mdcProperties = (taskDescription.properties.asScala ++
+ Seq((Executor.TASK_MDC_KEY, taskName)))
+ .filter(_._1.startsWith(Executor.MDC_KEY)).map { item =>
val key = item._1.substring(4)
+ if (key == Executor.TASK_MDC_KEY && item._2 != taskName) {
+ logWarning(s"Override mdc.taskName is not allowed, ignore ${item._2}")
Review comment:
Why we do not let override the task name in MDC?
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -969,4 +992,7 @@ private[spark] object Executor {
// task is fully deserialized. When possible, the TaskContext.getLocalProperty call should be
// used instead.
val taskDeserializationProps: ThreadLocal[Properties] = new ThreadLocal[Properties]
+
+ val MDC_KEY = "mdc."
+ val TASK_MDC_KEY = s"${MDC_KEY}taskName"
Review comment:
if you change this key you need also to update the docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642518002
@cloud-fan @igreenfield Have updated according to your comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] igreenfield commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
igreenfield commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438638104
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -969,4 +992,7 @@ private[spark] object Executor {
// task is fully deserialized. When possible, the TaskContext.getLocalProperty call should be
// used instead.
val taskDeserializationProps: ThreadLocal[Properties] = new ThreadLocal[Properties]
+
+ val MDC_KEY = "mdc."
+ val TASK_MDC_KEY = s"${MDC_KEY}taskName"
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642520313
**[Test build #123842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123842/testReport)** for PR 28756 at commit [`0cefc61`](https://github.com/apache/spark/commit/0cefc616952a22f3d66d79e793e8efb2e62d009a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642534353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438141988
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -401,9 +405,22 @@ private[spark] class Executor(
}
override def run(): Unit = {
+ val oldMdcProperties = mdcProperties.keys.map(k => (k, MDC.get(k)))
Review comment:
Can we simply clear all the mdc properties here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438580524
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -322,11 +322,15 @@ private[spark] class Executor(
val taskId = taskDescription.taskId
val threadName = s"Executor task launch worker for task $taskId"
val taskName = taskDescription.name
- val mdcProperties = taskDescription.properties.asScala
- .filter(_._1.startsWith("mdc.")).map { item =>
+ val mdcProperties = (taskDescription.properties.asScala ++
+ Seq((Executor.TASK_MDC_KEY, taskName)))
+ .filter(_._1.startsWith(Executor.MDC_KEY)).map { item =>
val key = item._1.substring(4)
+ if (key == Executor.TASK_MDC_KEY && item._2 != taskName) {
+ logWarning(s"Override mdc.taskName is not allowed, ignore ${item._2}")
Review comment:
What's the benefit to let users override the task name? It's just confusing to me. Let's not support a non-existing use case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] igreenfield commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
igreenfield commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438621749
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -322,11 +322,15 @@ private[spark] class Executor(
val taskId = taskDescription.taskId
val threadName = s"Executor task launch worker for task $taskId"
val taskName = taskDescription.name
- val mdcProperties = taskDescription.properties.asScala
- .filter(_._1.startsWith("mdc.")).map { item =>
+ val mdcProperties = (taskDescription.properties.asScala ++
+ Seq((Executor.TASK_MDC_KEY, taskName)))
+ .filter(_._1.startsWith(Executor.MDC_KEY)).map { item =>
val key = item._1.substring(4)
+ if (key == Executor.TASK_MDC_KEY && item._2 != taskName) {
+ logWarning(s"Override mdc.taskName is not allowed, ignore ${item._2}")
Review comment:
in the UI you can set the description I think many users can benefit from setting the taskName to be the same as that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438633426
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -969,4 +992,7 @@ private[spark] object Executor {
// task is fully deserialized. When possible, the TaskContext.getLocalProperty call should be
// used instead.
val taskDeserializationProps: ThreadLocal[Properties] = new ThreadLocal[Properties]
+
+ val MDC_KEY = "mdc."
+ val TASK_MDC_KEY = s"${MDC_KEY}taskName"
Review comment:
It affects end-users, as now they need to use `mdc.taskName` in the log4j config file, instead of `taskName`.
But it's not released yet, I'm fine to make it consistent that all the MDC properties start with `mdc.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438624432
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -322,11 +322,15 @@ private[spark] class Executor(
val taskId = taskDescription.taskId
val threadName = s"Executor task launch worker for task $taskId"
val taskName = taskDescription.name
- val mdcProperties = taskDescription.properties.asScala
- .filter(_._1.startsWith("mdc.")).map { item =>
+ val mdcProperties = (taskDescription.properties.asScala ++
+ Seq((Executor.TASK_MDC_KEY, taskName)))
+ .filter(_._1.startsWith(Executor.MDC_KEY)).map { item =>
val key = item._1.substring(4)
+ if (key == Executor.TASK_MDC_KEY && item._2 != taskName) {
+ logWarning(s"Override mdc.taskName is not allowed, ignore ${item._2}")
Review comment:
then, they can use custom MDC properties instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642607548
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28756: [SPARK-8981][CORE][FOLLOW-UP] Clean up MDC properties after running a task
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28756:
URL: https://github.com/apache/spark/pull/28756#issuecomment-642606432
**[Test build #123842 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123842/testReport)** for PR 28756 at commit [`0cefc61`](https://github.com/apache/spark/commit/0cefc616952a22f3d66d79e793e8efb2e62d009a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org