You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/19 10:31:32 UTC
[GitHub] [incubator-seatunnel] legendtkl opened a new pull request, #1923: [Feature][Flink-SQL-connector] add flink sql connector elasticsearch 6&7 and docs
legendtkl opened a new pull request, #1923:
URL: https://github.com/apache/incubator-seatunnel/pull/1923
## Purpose of this pull request
issue link https://github.com/apache/incubator-seatunnel/issues/1922
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] legendtkl commented on pull request #1923: [Feature][Flink-SQL-connector] add flink sql connector elasticsearch 6&7 and docs
Posted by GitBox <gi...@apache.org>.
legendtkl commented on PR #1923:
URL: https://github.com/apache/incubator-seatunnel/pull/1923#issuecomment-1131614401
> @legendtkl I see the code at `Executor`, can the CustomClassLoader load the plugin jar? it seems you don't add the jar path into the classloader before you execute below code.
>
> ```java
> Iterator<Factory> factories = ServiceLoader.load(Factory.class, CLASSLOADER).iterator();
> ```
Hi, @ruanwenjun , Flink SQL connector jars will not be added to the JVM classpath by default. We will add it to the classpath when we parse the SQL and find the connector Factory not in Classload.
This is what `Executor.loadConnector` method does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun merged pull request #1923: [Feature][Flink-SQL-connector] add flink sql connector elasticsearch 6&7 and docs
Posted by GitBox <gi...@apache.org>.
ruanwenjun merged PR #1923:
URL: https://github.com/apache/incubator-seatunnel/pull/1923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1923: [Feature][Flink-SQL-connector] add flink sql connector elasticsearch 6&7 and docs
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1923:
URL: https://github.com/apache/incubator-seatunnel/pull/1923#issuecomment-1131620741
> > @legendtkl I see the code at `Executor`, can the CustomClassLoader load the plugin jar? it seems you don't add the jar path into the classloader before you execute below code.
> > ```java
> > Iterator<Factory> factories = ServiceLoader.load(Factory.class, CLASSLOADER).iterator();
> > ```
>
> Hi, @ruanwenjun , Flink SQL connector jars will not be added to the JVM classpath by default. We will add it to the classpath when we parse the SQL and find the connector Factory not in Classloader.
>
> This is what `Executor.loadConnector` method does.
I understand. When the connector has not been loaded, you will find the connector jar and add to classoader. There is no problem.
```java
while (factories.hasNext()) {
Factory factory = factories.next();
/**
* Handle for two cases:
* 1. Flink built-in connectors.
* 2. Connectors have been placed in classpath.
*/
if (factory.factoryIdentifier().equals(connectorType)) {
return;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1923: [Feature][Flink-SQL-connector] add flink sql connector elasticsearch 6&7 and docs
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1923:
URL: https://github.com/apache/incubator-seatunnel/pull/1923#issuecomment-1131606765
@legendtkl I see the code at `Executor`, can the CustomClassLoader load the plugin jar? it seems you don't add the jar path into the classloader before you execute below code.
```java
Iterator<Factory> factories = ServiceLoader.load(Factory.class, CLASSLOADER).iterator();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] legendtkl commented on pull request #1923: [Feature][Flink-SQL-connector] add flink sql connector elasticsearch 6&7 and docs
Posted by GitBox <gi...@apache.org>.
legendtkl commented on PR #1923:
URL: https://github.com/apache/incubator-seatunnel/pull/1923#issuecomment-1131568109
Hi, @ruanwenjun , would you help review this PR?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org