You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:24:16 UTC

[GitHub] [arrow] nealrichardson commented on a change in pull request #11038: ARROW-13815 [R]: Adapt to new callstack changes in rlang

nealrichardson commented on a change in pull request #11038:
URL: https://github.com/apache/arrow/pull/11038#discussion_r699403585



##########
File path: r/R/metadata.R
##########
@@ -72,7 +72,10 @@ apply_arrow_r_metadata <- function(x, r_metadata) {
         # we cannot apply this row-level metadata, since the order of the rows is
         # not guaranteed to be the same, so don't even try, but warn what's going on
         trace <- trace_back()
-        in_dplyr_collect <- any(map_lgl(trace$calls, function(x) {
+        # TODO: remove the option munging once rlang > 0.4.11 is released
+        old_opts <- options(warnPartialMatchDollar = FALSE)
+        on.exit(options(old_opts))
+        in_dplyr_collect <- any(map_lgl(trace$call, function(x) {

Review comment:
       We could also do this and avoid messing with options:
   
   ```suggestion
           in_dplyr_collect <- any(map_lgl(trace$calls %||% trace$call, function(x) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org