You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/13 07:43:50 UTC
[GitHub] [apisix-helm-chart] zplinuxlover opened a new pull request, #284: could not install apisix-ingress if ingress-controller.enabled changed to true when helm install apisix charts
zplinuxlover opened a new pull request, #284:
URL: https://github.com/apache/apisix-helm-chart/pull/284
apisix chart and apisix-dashboard chart use {{ .Release.Namespace }}, when we change the config `ingress-controller.enabled` default behaviour, we could not install the apisix-ingress chart.
In apisix charts values.yaml
```
ingress-controller:
enabled: false
```
changed to
```
ingress-controller:
enabled: true
```
I want to install apisix and apisix-ingress at the same time. but apisix-ingress could not install successfully. In apisix chart, we do not specify the namesapce, we use {{ .Release.Namespace }}, but in apisix-ingress charts, we use the configured namespace in values.yaml
```
apisix:
serviceName: apisix-admin
#serviceNamespace: ingress-apisix
```
the code in apisix-ingress-controller charts deployment.yaml, we use a different namespace configured in values.yaml,
```
command: ['sh', '-c', "until nc -z {{ .Values.config.apisix.serviceName }}.{{ Values.config.apisix.serviceNamespace }}.svc.{{ .Values.clusterDomain }} {{ .Values.config.apisix.servicePort }} ;
```
the init container could not success, so the apisix ingress controller could not startup
<img width="938" alt="image" src="https://user-images.githubusercontent.com/23027077/168234140-e66ed99d-55cd-4af9-a490-f8b9a85fa44c.png">
we should use `.Release.Namespace` consistent with others charts, apisix charts and apisix-dashboard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] zplinuxlover commented on pull request #284: could not install apisix-ingress if ingress-controller.enabled changed to true when helm install apisix charts
Posted by GitBox <gi...@apache.org>.
zplinuxlover commented on PR #284:
URL: https://github.com/apache/apisix-helm-chart/pull/284#issuecomment-1125924257
should set serviceNamespace: ingress-apisix from ingress-apisix to default, hence user can use `helm install apisix .` in apisix charts dir to install all the components including apisix, apisix-ingress, apisix-ingress-controller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #284: could not install apisix-ingress if ingress-controller.enabled changed to true when helm install apisix charts
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #284:
URL: https://github.com/apache/apisix-helm-chart/pull/284#issuecomment-1125768552
```
helm install apisix apisix/apisix --set gateway.type=NodePort --set ingress-controller.enabled=true --set ingress-controller.config.apisix.serviceNamespace=apisix --namespace apisix --create-namespace --set ingress-controller.config.apisix.serviceName=apisix-admin
```
Thanks, you can pass `--set ingress-controller.config.apisix.serviceNamespace=apisix` and ` --set ingress-controller.config.apisix.serviceName=apisix-admin` .
Release Namespace is not used directly because of the scenario of a standalone installation of the APISIX Ingress controller (although it is not recommended)
I don't think this change is reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] zplinuxlover closed pull request #284: could not install apisix-ingress if ingress-controller.enabled changed to true when helm install apisix charts
Posted by "zplinuxlover (via GitHub)" <gi...@apache.org>.
zplinuxlover closed pull request #284: could not install apisix-ingress if ingress-controller.enabled changed to true when helm install apisix charts
URL: https://github.com/apache/apisix-helm-chart/pull/284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #284: could not install apisix-ingress if ingress-controller.enabled changed to true when helm install apisix charts
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #284:
URL: https://github.com/apache/apisix-helm-chart/pull/284#issuecomment-1126648297
But this won't work if APISIX and APISIX Ingress are in different namespaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org