You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ha...@apache.org on 2019/12/13 03:04:29 UTC

[skywalking] branch servicemesh-reg created (now 8803645)

This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a change to branch servicemesh-reg
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


      at 8803645  Remove client side endpoint register of service mesh

This branch includes the following new commits:

     new 8803645  Remove client side endpoint register of service mesh

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[skywalking] 01/01: Remove client side endpoint register of service mesh

Posted by ha...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a commit to branch servicemesh-reg
in repository https://gitbox.apache.org/repos/asf/skywalking.git

commit 880364524bbe969f82591d5292370322ece0b0d5
Author: Gao Hongtao <ha...@gmail.com>
AuthorDate: Fri Dec 13 11:04:07 2019 +0800

    Remove client side endpoint register of service mesh
---
 .../receiver/mesh/ServiceMeshMetricDataDecorator.java       | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/oap-server/server-receiver-plugin/skywalking-mesh-receiver-plugin/src/main/java/org/apache/skywalking/aop/server/receiver/mesh/ServiceMeshMetricDataDecorator.java b/oap-server/server-receiver-plugin/skywalking-mesh-receiver-plugin/src/main/java/org/apache/skywalking/aop/server/receiver/mesh/ServiceMeshMetricDataDecorator.java
index f3ea308..e00124f 100644
--- a/oap-server/server-receiver-plugin/skywalking-mesh-receiver-plugin/src/main/java/org/apache/skywalking/aop/server/receiver/mesh/ServiceMeshMetricDataDecorator.java
+++ b/oap-server/server-receiver-plugin/skywalking-mesh-receiver-plugin/src/main/java/org/apache/skywalking/aop/server/receiver/mesh/ServiceMeshMetricDataDecorator.java
@@ -95,24 +95,15 @@ public class ServiceMeshMetricDataDecorator {
         }
         String endpoint = origin.getEndpoint();
 
+        // Service mesh doesn't register client side endpoint.
         DetectPoint point = origin.getDetectPoint();
-        if (DetectPoint.client.equals(point)) {
-            if (sourceServiceId != Const.NONE) {
-                endpointId = CoreRegisterLinker.getEndpointInventoryRegister().getOrCreate(sourceServiceId, endpoint,
-                    org.apache.skywalking.oap.server.core.source.DetectPoint.fromNetworkProtocolDetectPoint(point));
-            }
-        } else {
+        if (DetectPoint.server.equals(point)) {
             if (destServiceId != Const.NONE) {
                 endpointId = CoreRegisterLinker.getEndpointInventoryRegister().getOrCreate(destServiceId, endpoint,
                     org.apache.skywalking.oap.server.core.source.DetectPoint.fromNetworkProtocolDetectPoint(point));
             }
         }
 
-        if (endpointId != Const.NONE) {
-        } else {
-            isRegistered = false;
-        }
-
         return isRegistered;
     }