You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2018/02/15 10:18:00 UTC
Review Request 65671: Added comparison operators for operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65671/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-8424
https://issues.apache.org/jira/browse/MESOS-8424
Repository: mesos
Description
-------
Added comparison operators for operations.
Diffs
-----
include/mesos/type_utils.hpp af2b187b9b59552e4ba515ad640fd4419eaf5075
include/mesos/v1/mesos.hpp f16568ef37ff954f1d28f13f062be9c9f078d2a4
src/common/type_utils.cpp a4d5dcb4e4445e307356d9b0c16dd39f00f6a8e2
src/v1/mesos.cpp 576f367f1974111be5eee3f3c4cc7cc9a8bbc154
Diff: https://reviews.apache.org/r/65671/diff/1/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 65671: Added comparison operators for operations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65671/
-----------------------------------------------------------
(Updated Feb. 16, 2018, 4:35 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Addressed issues.
Bugs: MESOS-8424
https://issues.apache.org/jira/browse/MESOS-8424
Repository: mesos
Description
-------
Added comparison operators for operations.
Diffs (updated)
-----
include/mesos/type_utils.hpp af2b187b9b59552e4ba515ad640fd4419eaf5075
include/mesos/v1/mesos.hpp f16568ef37ff954f1d28f13f062be9c9f078d2a4
src/common/type_utils.cpp a4d5dcb4e4445e307356d9b0c16dd39f00f6a8e2
src/v1/mesos.cpp 576f367f1974111be5eee3f3c4cc7cc9a8bbc154
Diff: https://reviews.apache.org/r/65671/diff/2/
Changes: https://reviews.apache.org/r/65671/diff/1-2/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 65671: Added comparison operators for operations.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65671/#review197669
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/type_utils.hpp
Lines 65 (patched)
<https://reviews.apache.org/r/65671/#comment277902>
Let's use the nested type `Offer::Operation` when referring to this type.
include/mesos/type_utils.hpp
Lines 88 (patched)
<https://reviews.apache.org/r/65671/#comment277903>
Ditto.
include/mesos/v1/mesos.hpp
Lines 63 (patched)
<https://reviews.apache.org/r/65671/#comment277904>
Ditto.
include/mesos/v1/mesos.hpp
Lines 79 (patched)
<https://reviews.apache.org/r/65671/#comment277905>
Ditto.
- Benjamin Bannier
On Feb. 15, 2018, 11:17 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65671/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2018, 11:17 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added comparison operators for operations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp af2b187b9b59552e4ba515ad640fd4419eaf5075
> include/mesos/v1/mesos.hpp f16568ef37ff954f1d28f13f062be9c9f078d2a4
> src/common/type_utils.cpp a4d5dcb4e4445e307356d9b0c16dd39f00f6a8e2
> src/v1/mesos.cpp 576f367f1974111be5eee3f3c4cc7cc9a8bbc154
>
>
> Diff: https://reviews.apache.org/r/65671/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>