You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/10/28 00:01:28 UTC

[GitHub] [commons-math] tongxin97 opened a new pull request #162: [MATH-1559] Fix assertion failure with epsilon

tongxin97 opened a new pull request #162:
URL: https://github.com/apache/commons-math/pull/162


   For detailed description of the issue, see: https://issues.apache.org/jira/browse/MATH-1559
   
   If we just want to change the test so that it will always pass, this PR achieves it by setting a small epsilon (1e-15) in `assertEquals(0.5, distribution.probability(2), 1e-15)`. Otherwise to fix the issue, the source code, in particular `MathArrays.normalizeArray()` needs change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] coveralls commented on pull request #162: [MATH-1559] Fix assertion failure with epsilon

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #162:
URL: https://github.com/apache/commons-math/pull/162#issuecomment-717614400


   
   [![Coverage Status](https://coveralls.io/builds/34511731/badge)](https://coveralls.io/builds/34511731)
   
   Coverage remained the same at 90.713% when pulling **bc61789aef97795c885d80ecc3978435b362abf8 on tongxin97:fix-testCreateFromDoubles** into **43b77ffabba8a48144080674973362150cbcfb28 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org