You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/11/04 04:25:22 UTC
[GitHub] [carbondata] manishnalla1994 commented on a change in pull request
#3426: [CARBONDATA-3560] Fixed issues for Add Segment
manishnalla1994 commented on a change in pull request #3426: [CARBONDATA-3560] Fixed issues for Add Segment
URL: https://github.com/apache/carbondata/pull/3426#discussion_r341901364
##########
File path: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/addsegment/AddSegmentTestCase.scala
##########
@@ -542,7 +541,7 @@ class AddSegmentTestCase extends QueryTest with BeforeAndAfterAll {
copy(path.toString, newPath)
checkAnswer(sql("select count(*) from addsegment1"), Seq(Row(30)))
- sql(s"alter table addsegment1 add segment options('path'='$newPath', 'format'='parquet')").show()
+ sql(s"alter table addsegment1 add segment options('path'='$newPath', 'format'='PARQUET')").show()
Review comment:
This change is required just for the testing purpose of uppercase format, so that I need not add a new testcase just for case sensitivity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services