You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brad Schoening (Jira)" <ji...@apache.org> on 2023/07/14 16:17:00 UTC
[jira] (CASSANDRA-18659) Upgrade apache commons cli to 1.5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-18659 ]
Brad Schoening deleted comment on CASSANDRA-18659:
--------------------------------------------
was (Author: bschoeni):
It's odd, the table split tool's classes define a help option:
[https://github.com/apache/cassandra/blob/e1175aa6dc3f7863fde7dea0c6096116415091a7/src/java/org/apache/cassandra/tools/StandaloneSplitter.java#L62]
{code:java}
private static CmdLineOptions getCmdLineOptions()
{
CmdLineOptions options = new CmdLineOptions();
options.addOption(null, DEBUG_OPTION, "display stack traces");
options.addOption("h", HELP_OPTION, "display this help message");
options.addOption(null, NO_SNAPSHOT_OPTION, "don't snapshot the sstables before splitting");
options.addOption("s", SIZE_OPTION, "size", "maximum size in MB for the output sstables (default: " + DEFAULT_SSTABLE_SIZE + ')');
return options;
{code}
Where CmdLineOptions is imported from org.apache.cassandra.tools.BulkLoader.CmdLineOptions;
I'm not loving the style here of sharing of an internal class from BulkLoader, and OptionsBuilder has been deprecated in apache commons cli 1.3, so there may be more work here to refactor the options.
> Upgrade apache commons cli to 1.5.0
> -----------------------------------
>
> Key: CASSANDRA-18659
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18659
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
> Reporter: Timothy Tu
> Assignee: Timothy Tu
> Priority: Normal
> Fix For: 5.x
>
>
> Upgrade apache commons-cli from 1.1 (July 2007) to 1.5.0 (October 2021).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org