You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@daffodil.apache.org by GitBox <gi...@apache.org> on 2018/04/04 16:37:48 UTC

[GitHub] stevedlawrence commented on a change in pull request #56: Improved toString of grammar and parser/unparser objects.

stevedlawrence commented on a change in pull request #56: Improved toString of grammar and parser/unparser objects.
URL: https://github.com/apache/incubator-daffodil/pull/56#discussion_r179205715
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/Grammar.scala
 ##########
 @@ -192,9 +197,9 @@ abstract class Terminal(contextArg: SchemaComponent, guard: Boolean)
 
   override def isEmpty = !guard
 
-  private lazy val realSC = context.asInstanceOf[SchemaComponent]
-  final override lazy val path = realSC.path + "@@" + diagnosticDebugName
-
-  override def toString = path // dangerous. What if realSC.path fails?
+  //  private lazy val realSC = context.asInstanceOf[SchemaComponent]
+  //  final override lazy val path = realSC.path + "@@" + diagnosticDebugName
+  //
+  //  override def toString = path // dangerous. What if realSC.path fails?
 
 Review comment:
   Remove comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services