You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/11 07:40:28 UTC
[GitHub] [maven-wrapper] gzm55 opened a new pull request, #65: [MWRAPPER-80] support maven-mvnd
gzm55 opened a new pull request, #65:
URL: https://github.com/apache/maven-wrapper/pull/65
Try to integrate maven-mvnd as a maven distribution. Now `only-mvnw` works fine without sha256 checksum verification.
- manual select platform: distributionUrl=https://downloads.apache.org/maven/mvnd/0.8.2/maven-mvnd-0.8.2-darwin-amd64.zip
- auto select platform: distributionUrl=https://downloads.apache.org/maven/mvnd/0.8.2/maven-mvnd-0.8.2-bin.zip
In the auto mode, the script selects a proper platform via the result of "uname -a", or fallback to the pure java version for unknown platform. For `distributionSha256Sum`, we also need new pattern to support multiple checksums, such as `distributionSha256Sum=darwin-aarch64:111;linux-amd64:222`
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] gzm55 commented on pull request #65: [MWRAPPER-80] support maven-mvnd
Posted by GitBox <gi...@apache.org>.
gzm55 commented on PR #65:
URL: https://github.com/apache/maven-wrapper/pull/65#issuecomment-1374992444
> please also add IT test - to see how it works
IT test is added. The test case success on linux and macos, but failed on windows since not implemented in `mvnw.cmd`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] slawekjaranowski commented on pull request #65: [MWRAPPER-80] support maven-mvnd
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #65:
URL: https://github.com/apache/maven-wrapper/pull/65#issuecomment-1363016541
please also add IT test - to see how it works
What with additional task per OS, like for macOs `xattr -r -d ...`?
https://github.com/apache/maven-mvnd#install-manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] gzm55 commented on pull request #65: [MWRAPPER-80] support maven-mvnd
Posted by GitBox <gi...@apache.org>.
gzm55 commented on PR #65:
URL: https://github.com/apache/maven-wrapper/pull/65#issuecomment-1373951163
> What with additional task per OS, like for macOs `xattr -r -d ...`?
>
> https://github.com/apache/maven-mvnd#install-manually
The "com.apple.quarantine" extended attribute is set when the zip/tgz files are downloaded by the browsers, and not set when downloaded by curl/wget/java. This is tested on macos since 10.15. And the original maven distribution installed by wrapper also relies on this behavior. So the `xattr -r -d ...` step is not required by the wrapper for both original maven and mvnd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell commented on pull request #65: [MWRAPPER-80] support maven-mvnd
Posted by GitBox <gi...@apache.org>.
bmarwell commented on PR #65:
URL: https://github.com/apache/maven-wrapper/pull/65#issuecomment-1374865055
> and not set when downloaded by curl/wget/java
Yes this is true, for whatever reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] gzm55 commented on pull request #65: [MWRAPPER-80] support maven-mvnd
Posted by GitBox <gi...@apache.org>.
gzm55 commented on PR #65:
URL: https://github.com/apache/maven-wrapper/pull/65#issuecomment-1375993476
@slawekjaranowski @bmarwell `mvnw` and `mvnw.cmd` both pass the IT test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] gzm55 commented on pull request #65: [MWRAPPER-80] support maven-mvnd
Posted by "gzm55 (via GitHub)" <gi...@apache.org>.
gzm55 commented on PR #65:
URL: https://github.com/apache/maven-wrapper/pull/65#issuecomment-1413033326
@slawekjaranowski could you give some suggestions or review for this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] slawekjaranowski commented on pull request #65: [MWRAPPER-80] support maven-mvnd
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #65:
URL: https://github.com/apache/maven-wrapper/pull/65#issuecomment-1435722435
If we support only `only-script` WrapperMojo should detect it and set proper `distributionType` in other case it will not works ... I'm right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] nicoloboschi commented on pull request #65: [MWRAPPER-80] support maven-mvnd
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #65:
URL: https://github.com/apache/maven-wrapper/pull/65#issuecomment-1362638693
This is a great feature!
@bmarwell @amitmisra-ww @slawekjaranowski PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] gzm55 commented on pull request #65: [MWRAPPER-80] support maven-mvnd
Posted by "gzm55 (via GitHub)" <gi...@apache.org>.
gzm55 commented on PR #65:
URL: https://github.com/apache/maven-wrapper/pull/65#issuecomment-1435834190
> If we support only `only-script` WrapperMojo should detect it and set proper `distributionType` in other case it will not works ... I'm right?
yes, a fast-fail check is added in `execute()` of the mojo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] slawekjaranowski merged pull request #65: [MWRAPPER-80] support maven-mvnd
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #65:
URL: https://github.com/apache/maven-wrapper/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org