You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "SteNicholas (via GitHub)" <gi...@apache.org> on 2024/03/01 07:13:20 UTC
[PR] [SPARK-47242][CONNECT][PROFILER] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]
SteNicholas opened a new pull request, #45351:
URL: https://github.com/apache/spark/pull/45351
### What changes were proposed in this pull request?
Bump ap-loader from 3.0(v8) to support for async-profiler 3.0.
### Why are the changes needed?
ap-loader 3.0(v8) has already been released, which supports for async-profier 3.0. The release guide refers to [Loader for 3.0 (v8): Binary launcher and AsyncGetCallTrace replacement|https://github.com/jvm-profiling-tools/ap-loader/releases/tag/3.0-8].
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #45351:
URL: https://github.com/apache/spark/pull/45351#issuecomment-1975495691
The original PR does not have its test together (https://github.com/apache/spark/pull/44021). @SteNicholas Mind describing how you tested this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #45351: [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0
URL: https://github.com/apache/spark/pull/45351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #45351:
URL: https://github.com/apache/spark/pull/45351#issuecomment-1975460640
@parthchandra, thank you try it out. Have you tried anything wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on PR #45351:
URL: https://github.com/apache/spark/pull/45351#issuecomment-1977330468
> @parthchandra, thank you try it out. Have you tried anything wrong?
I was able to try it out locally (non production) and the jfr files written were fine. I didn't see much difference in the output for my job, but others may definitely benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47242][CONNECT][PROFILER] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45351:
URL: https://github.com/apache/spark/pull/45351#issuecomment-1972661591
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45351:
URL: https://github.com/apache/spark/pull/45351#issuecomment-1973807623
To @SteNicholas , for this kind of PR, we can use simply `[BUILD]` tag like GitHub Action bot suggested.
To @parthchandra , could you confirm that this works without any issues, please? We don't have a test coverage in CI, do we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #45351:
URL: https://github.com/apache/spark/pull/45351#issuecomment-1975895901
> The original PR does not have its test together (#44021). @SteNicholas Mind describing how you tested this?
@HyukjinKwon, I only tested this bump in production environment of Spark cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45351:
URL: https://github.com/apache/spark/pull/45351#issuecomment-1977336300
I added you to the Apache Spark contributor group, @SteNicholas , and assigned SPARK-47242 to you.
Welcome to the Apache Spark community!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on PR #45351:
URL: https://github.com/apache/spark/pull/45351#issuecomment-1974173364
Yes there is no good way to test this in ci. Let me try it out and make sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47242][CONNECT][PROFILER] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #45351:
URL: https://github.com/apache/spark/pull/45351#issuecomment-1972633096
cc @dongjoon-hyun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45351:
URL: https://github.com/apache/spark/pull/45351#issuecomment-1974828172
Thank you so much, @parthchandra !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47242][BUILD] Bump ap-loader 3.0(v8) to support for async-profiler 3.0 [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #45351:
URL: https://github.com/apache/spark/pull/45351#issuecomment-1975909802
That's fine. My point is that please describe it in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org