You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/08 19:53:32 UTC
[GitHub] [beam] MabelYC opened a new pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
MabelYC opened a new pull request #13926:
URL: https://github.com/apache/beam/pull/13926
Currently, org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class is in test jar, but InMemoryMetrics is needed when doing unit tests and local runs for spark runner. So move it out of test jar to support unit tests and local runs.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam
.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13926:
URL: https://github.com/apache/beam/pull/13926#issuecomment-788403885
You'll need to check the couple build issues:
https://scans.gradle.com/s/azabfuw37q6os/console-log?task=:runners:spark:checkstyleMain
```
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Phrase/src/runners/spark/src/main/java/org/apache/beam/runners/spark/aggregators/metrics/sink/InMemoryMetrics.java:1: Missing package-info.java file. [JavadocPackage]
```
and also you may need to run `./gradlew :runners:spark:spotbugsMain` to see what other spotbugs issues may have been found.
fyi @MabelYC
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13926:
URL: https://github.com/apache/beam/pull/13926#issuecomment-1030616598
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13926:
URL: https://github.com/apache/beam/pull/13926#issuecomment-788296460
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #13926:
URL: https://github.com/apache/beam/pull/13926#issuecomment-807161993
@MabelYC - What is the next step on this PR? Should we keep this open?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13926:
URL: https://github.com/apache/beam/pull/13926#issuecomment-786268674
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] MabelYC commented on pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
Posted by GitBox <gi...@apache.org>.
MabelYC commented on pull request #13926:
URL: https://github.com/apache/beam/pull/13926#issuecomment-775401890
R: @xinyuiscool
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] xinyuiscool commented on pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
Posted by GitBox <gi...@apache.org>.
xinyuiscool commented on pull request #13926:
URL: https://github.com/apache/beam/pull/13926#issuecomment-775461347
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] closed pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #13926:
URL: https://github.com/apache/beam/pull/13926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] closed pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #13926:
URL: https://github.com/apache/beam/pull/13926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #13926:
URL: https://github.com/apache/beam/pull/13926#issuecomment-797056153
@MabelYC - What is the next step on this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] MabelYC commented on pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
Posted by GitBox <gi...@apache.org>.
MabelYC commented on pull request #13926:
URL: https://github.com/apache/beam/pull/13926#issuecomment-826008236
> @MabelYC @xinyuiscool any updates? : )
Sorry for the late reply, just got my github account recovered. Will try to fix this next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] xinyuiscool commented on pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
Posted by GitBox <gi...@apache.org>.
xinyuiscool commented on pull request #13926:
URL: https://github.com/apache/beam/pull/13926#issuecomment-776163093
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13926:
URL: https://github.com/apache/beam/pull/13926#issuecomment-1037214423
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13926:
URL: https://github.com/apache/beam/pull/13926#issuecomment-1037214423
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #13926: [BEAM-11775]:Move org.apache.beam.runners.spark.aggregators.metrics.sink.InMemoryMetrics class out of test jar
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13926:
URL: https://github.com/apache/beam/pull/13926#issuecomment-816992750
@MabelYC @xinyuiscool any updates? : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org