You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/11/09 13:51:53 UTC

[GitHub] [iotdb] yschengzi opened a new pull request, #7954: [IOTDB-4771]BufferedPipeDataQueueTest.testOfferWhileTakingWithDiscontinuousSerialNumber fail

yschengzi opened a new pull request, #7954:
URL: https://github.com/apache/iotdb/pull/7954

   problem:
   BufferedPipeDataQueueTest.testOfferWhileTakingWithDiscontinuousSerialNumber fail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou merged pull request #7954: [IOTDB-4771]BufferedPipeDataQueueTest.testOfferWhileTakingWithDiscontinuousSerialNumber fail

Posted by GitBox <gi...@apache.org>.
HTHou merged PR #7954:
URL: https://github.com/apache/iotdb/pull/7954


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a diff in pull request #7954: [IOTDB-4771]BufferedPipeDataQueueTest.testOfferWhileTakingWithDiscontinuousSerialNumber fail

Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #7954:
URL: https://github.com/apache/iotdb/pull/7954#discussion_r1018066792


##########
server/src/main/java/org/apache/iotdb/db/sync/pipedata/queue/BufferedPipeDataQueue.java:
##########
@@ -194,10 +194,10 @@ public boolean offer(PipeData pipeData) {
         logger.error(String.format("Move to next pipe log %s error.", pipeData), e);
       }
     }
-    if (!inputDeque.offer(pipeData)) {
-      return false;
-    }
     synchronized (waitLock) {
+      if (!inputDeque.offer(pipeData)) {
+        return false;
+      }
       waitLock.notifyAll();

Review Comment:
   If return false here, we don't need to call waitLock.notifyAll()?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org