You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/11 08:13:36 UTC
[GitHub] [flink-table-store] zjureel opened a new pull request, #314: [FLINK-28128] Add e2e test for spark reader
zjureel opened a new pull request, #314:
URL: https://github.com/apache/flink-table-store/pull/314
Add e2e test for spark reader, the operations in the test case are as follows:
1. Setup flink docker cluster to write data to file
2. Setup spark docker cluster to read the schema and data, validate the results for 5 different queries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #314: [FLINK-28128] Add e2e test for spark reader
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #314:
URL: https://github.com/apache/flink-table-store/pull/314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #314: [FLINK-28128] Add e2e test for spark reader
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #314:
URL: https://github.com/apache/flink-table-store/pull/314#discussion_r992939690
##########
flink-table-store-e2e-tests/src/test/java/org/apache/flink/table/store/tests/SparkE2eTest.java:
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.store.tests;
+
+import org.apache.commons.lang3.StringUtils;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.DisabledIfSystemProperty;
+import org.testcontainers.containers.Container;
+import org.testcontainers.containers.ContainerState;
+
+import java.util.Arrays;
+import java.util.UUID;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/** Tests for reading table store from Spark3. */
+@DisabledIfSystemProperty(named = "flink.version", matches = "1.14.*")
+public class SparkE2eTest extends E2eTestBase {
+
+ public SparkE2eTest() {
+ super(false, false, true);
+ }
+
+ @Test
+ public void testFlinkWriteAndSparkRead() throws Exception {
Review Comment:
Can we extract a abstract class for `SparkE2eTest` and `HiveE2eTest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] zjureel commented on pull request #314: [FLINK-28128] Add e2e test for spark reader
Posted by GitBox <gi...@apache.org>.
zjureel commented on PR #314:
URL: https://github.com/apache/flink-table-store/pull/314#issuecomment-1274288070
Hi @JingsongLi I have added a e2e test for spark reader, can you help to review the codes? THX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on pull request #314: [FLINK-28128] Add e2e test for spark reader
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on PR #314:
URL: https://github.com/apache/flink-table-store/pull/314#issuecomment-1275519030
Thanks @zjureel , I just left one minor comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] zjureel commented on pull request #314: [FLINK-28128] Add e2e test for spark reader
Posted by GitBox <gi...@apache.org>.
zjureel commented on PR #314:
URL: https://github.com/apache/flink-table-store/pull/314#issuecomment-1276273061
@JingsongLi Thanks for your comments, and I have updated the codes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org