You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by "Ate Douma (JIRA)" <je...@portals.apache.org> on 2009/03/31 11:59:50 UTC

[jira] Created: (JS2-947) Properly handling container invocation errors like processAction throwing an unexcepted exception and displaying a meaningful message to the end user

Properly handling container invocation errors like processAction throwing an unexcepted exception and displaying a meaningful message to the end user
-----------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: JS2-947
                 URL: https://issues.apache.org/jira/browse/JS2-947
             Project: Jetspeed 2
          Issue Type: Improvement
          Components: Container
    Affects Versions: 2.2
            Reporter: Ate Douma
             Fix For: 2.2


For example in the ActionValveImpl, we trap all exceptions (except PortletContainerException) thrown by the container invocation, only log them, and then simply invoke with the next Valve...
For example with a NPE thrown like currently in the the JSF-Demo when you click on the Root tree node, the following meaningless end message is shown on the page:

  Portlet is Not Available: jsf-demo::guessNumber
  Reason: null 

I think we either should come up with a pluggable ErrorHandlingValve or else send a response error (which then could be "trapped" itself with a configured error handling page in web.xml)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] Resolved: (JS2-947) Properly handling container invocation errors like processAction throwing an unexcepted exception and displaying a meaningful message to the end user

Posted by "Ate Douma (JIRA)" <je...@portals.apache.org>.
     [ https://issues.apache.org/jira/browse/JS2-947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ate Douma resolved JS2-947.
---------------------------

    Resolution: Fixed

Fixed by leveraging the new RequestDiagnostics feature from JS2-992

> Properly handling container invocation errors like processAction throwing an unexcepted exception and displaying a meaningful message to the end user
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JS2-947
>                 URL: https://issues.apache.org/jira/browse/JS2-947
>             Project: Jetspeed 2
>          Issue Type: Improvement
>          Components: Container
>    Affects Versions: 2.2.0
>            Reporter: Ate Douma
>            Assignee: Ate Douma
>             Fix For: 2.2.0
>
>
> For example in the ActionValveImpl, we trap all exceptions (except PortletContainerException) thrown by the container invocation, only log them, and then simply invoke with the next Valve...
> For example with a NPE thrown like currently in the the JSF-Demo when you click on the Root tree node, the following meaningless end message is shown on the page:
>   Portlet is Not Available: jsf-demo::guessNumber
>   Reason: null 
> I think we either should come up with a pluggable ErrorHandlingValve or else send a response error (which then could be "trapped" itself with a configured error handling page in web.xml)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] Assigned: (JS2-947) Properly handling container invocation errors like processAction throwing an unexcepted exception and displaying a meaningful message to the end user

Posted by "Ate Douma (JIRA)" <je...@portals.apache.org>.
     [ https://issues.apache.org/jira/browse/JS2-947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ate Douma reassigned JS2-947:
-----------------------------

    Assignee: Ate Douma

> Properly handling container invocation errors like processAction throwing an unexcepted exception and displaying a meaningful message to the end user
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JS2-947
>                 URL: https://issues.apache.org/jira/browse/JS2-947
>             Project: Jetspeed 2
>          Issue Type: Improvement
>          Components: Container
>    Affects Versions: 2.2.0
>            Reporter: Ate Douma
>            Assignee: Ate Douma
>             Fix For: 2.2.0
>
>
> For example in the ActionValveImpl, we trap all exceptions (except PortletContainerException) thrown by the container invocation, only log them, and then simply invoke with the next Valve...
> For example with a NPE thrown like currently in the the JSF-Demo when you click on the Root tree node, the following meaningless end message is shown on the page:
>   Portlet is Not Available: jsf-demo::guessNumber
>   Reason: null 
> I think we either should come up with a pluggable ErrorHandlingValve or else send a response error (which then could be "trapped" itself with a configured error handling page in web.xml)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org