You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hop.apache.org by GitBox <gi...@apache.org> on 2021/03/15 19:35:05 UTC
[GitHub] [incubator-hop] bamaer opened a new pull request #675: HOP-2621, HOP-2622: small fixes in Google Analytics and importer
bamaer opened a new pull request #675:
URL: https://github.com/apache/incubator-hop/pull/675
Following this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/HOP) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[HOP-XXX] - Fixes bug in SessionManager`,
where you replace `HOP-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like `(DOC) - Add javadoc in SessionManager`.
If this is your first contribution, you have to read the [Contribution Guidelines](https://hop.apache.org/community/contributing/)
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mattcasters merged pull request #675: HOP-2621, HOP-2622: small fixes in Google Analytics and importer
Posted by GitBox <gi...@apache.org>.
mattcasters merged pull request #675:
URL: https://github.com/apache/incubator-hop/pull/675
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [GitHub] [incubator-hop] bamaer opened a new pull request #675: HOP-2621, HOP-2622: small fixes in Google Analytics and importer
Posted by Justin Mclean <jm...@apache.org>.
Hi,
> Thanks for the link! Is this something that can be added to the Podling
> guides (maybe under the website section)?
Yes it should be added there, I was waiting until there was an official policy, but that's taken longer than expected to happen.
Thanks,
Justin
Re: [GitHub] [incubator-hop] bamaer opened a new pull request #675:
HOP-2621, HOP-2622: small fixes in Google Analytics and importer
Posted by Hans Van Akelyen <ha...@gmail.com>.
Hi Justin,
Thanks for the link! Is this something that can be added to the Podling
guides (maybe under the website section)?
It's the first time I've seen these guidelines and I suspect more podlings
will face these issues at some point.
Cheers,
Hans
On Fri, 19 Mar 2021 at 10:30, Justin Mclean <jm...@apache.org> wrote:
> Hi,
>
> See also:
> https://privacy.apache.org/faq/committers.html
>
> Thanks,
> Justin
>
Re: [GitHub] [incubator-hop] bamaer opened a new pull request #675: HOP-2621, HOP-2622: small fixes in Google Analytics and importer
Posted by Justin Mclean <jm...@apache.org>.
Hi,
See also:
https://privacy.apache.org/faq/committers.html
Thanks,
Justin
Re: [GitHub] [incubator-hop] bamaer opened a new pull request #675: HOP-2621, HOP-2622: small fixes in Google Analytics and importer
Posted by Justin Mclean <jm...@apache.org>.
HI,
> This PR is a "Transform/Data Processing step" to support processing GA data
> in our software, it is not related to our site.
Thanks for the clarification.
> It's a shame this is no longer allowed as it provides valuable insights on
> site usage and areas that need improvement.
Currently it is allowed, but it very likely that in the near future that all projects will be asked not to use Google Analytics due to risk of legal action and privacy concerns.
> Please note that we do present a banner to accept cookies
You need to do more than that under current privacy legislation. For instance you need to have a privacy policy on your web site.
The best place to discuss this, what your project needs and the best way to do that, is on the privacy list.
Thanks,
Justin
Re: [GitHub] [incubator-hop] bamaer opened a new pull request #675:
HOP-2621, HOP-2622: small fixes in Google Analytics and importer
Posted by Hans Van Akelyen <ha...@gmail.com>.
Hi Justin,
This PR is a "Transform/Data Processing step" to support processing GA data
in our software, it is not related to our site.
But we do use GA on our website...
It's a shame this is no longer allowed as it provides valuable insights on
site usage and areas that need improvement.
By monitoring page usage we can see which areas of the software are unclear
to end users, It allows us to track interesting remote referrals that we
can share with our community. Well many of the same reasons the Airflow
team is pointing at...
Please note that we do present a banner to accept cookies, rejecting (or
ignoring) this will result in not being followed and we also respect the
doNotTrack some browsers send.
A general x visits per day as Infra currently provides does not really help
us, I would even say that the amount of visits is the one thing we do not
care about. It's a fun thing to see, but we want our users to find the
information they need or want to know what areas they are struggling with.
Cheers,
Hans
On Fri, 19 Mar 2021 at 05:08, Justin Mclean <jm...@apache.org> wrote:
> Hi,
>
> It probably best not to use Google Analytics as the ASF currently
> discourages it use. Please see:
> https://issues.apache.org/jira/browse/LEGAL-470
>
> Thanks,
> Justin
>
Re: [GitHub] [incubator-hop] bamaer opened a new pull request #675: HOP-2621, HOP-2622: small fixes in Google Analytics and importer
Posted by Justin Mclean <jm...@apache.org>.
Hi,
It probably best not to use Google Analytics as the ASF currently discourages it use. Please see: https://issues.apache.org/jira/browse/LEGAL-470
Thanks,
Justin