You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "rcsim (via GitHub)" <gi...@apache.org> on 2023/10/21 13:39:52 UTC

[PR] boards/stm32: add support to STM32F401RC-RS485 board [nuttx]

rcsim opened a new pull request, #10990:
URL: https://github.com/apache/nuttx/pull/10990

   ## Summary
   The STM32F401RC-RS485 is a board with RS485 support, SD Card, buttons, leds, temperature sensor, adc and etc.
   
   ## Impact
   User will be able to use this new board STM32F401RC-RS485.
   
   ## Testing
   Build basic shell application and ran on STM32F401RC-RS485 board.
   
   P.S.: Documentation will be sent in a different commit ad we need to format it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] boards/stm32: add support to STM32F401RC-RS485 board [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #10990:
URL: https://github.com/apache/nuttx/pull/10990#discussion_r1367745640


##########
boards/Kconfig:
##########
@@ -1589,6 +1589,17 @@ config ARCH_BOARD_NUCLEO_F401RE
 		This is a minimal configuration that supports low-level test of the
 		Nucleo F401RE in the NuttX source tree.
 
+config ARCH_BOARD_STM32F401RC_RS485
+	bool "STM32F401RC-RS485 Board"
+	depends on ARCH_CHIP_STM32F401RC
+	select ARCH_HAVE_LEDS
+	select ARCH_HAVE_BUTTONS
+	select ARCH_HAVE_IRQBUTTONS
+	---help---
+		This is a minimal configuration that supports low-level test of the
+		STM32F401RC-RS485 in the NuttX source tree.
+
+

Review Comment:
   Please remove an extra empty line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] boards/stm32: add support to STM32F401RC-RS485 board [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10990:
URL: https://github.com/apache/nuttx/pull/10990#discussion_r1367737207


##########
boards/Kconfig:
##########
@@ -1397,6 +1397,8 @@ config ARCH_BOARD_BEAGLEBONE_BLACK
 	---help---
 		This is the port of NuttX to the TI Beaglebone Black board.
 
+
+

Review Comment:
   why change



##########
boards/Kconfig:
##########
@@ -1432,14 +1434,6 @@ config ARCH_BOARD_PIC32MZ_STARTERKIT
 
 		See www.microchip.com for further information.
 
-config ARCH_BOARD_NUCLEO_F429ZI

Review Comment:
   why delete



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] boards/stm32: add support to STM32F401RC-RS485 board [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #10990:
URL: https://github.com/apache/nuttx/pull/10990#discussion_r1367745640


##########
boards/Kconfig:
##########
@@ -1589,6 +1589,17 @@ config ARCH_BOARD_NUCLEO_F401RE
 		This is a minimal configuration that supports low-level test of the
 		Nucleo F401RE in the NuttX source tree.
 
+config ARCH_BOARD_STM32F401RC_RS485
+	bool "STM32F401RC-RS485 Board"
+	depends on ARCH_CHIP_STM32F401RC
+	select ARCH_HAVE_LEDS
+	select ARCH_HAVE_BUTTONS
+	select ARCH_HAVE_IRQBUTTONS
+	---help---
+		This is a minimal configuration that supports low-level test of the
+		STM32F401RC-RS485 in the NuttX source tree.
+
+

Review Comment:
   Please remove a extra empty line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] boards/stm32: add support to STM32F401RC-RS485 board [nuttx]

Posted by "rcsim (via GitHub)" <gi...@apache.org>.
rcsim commented on code in PR #10990:
URL: https://github.com/apache/nuttx/pull/10990#discussion_r1367741710


##########
boards/Kconfig:
##########
@@ -1432,14 +1434,6 @@ config ARCH_BOARD_PIC32MZ_STARTERKIT
 
 		See www.microchip.com for further information.
 
-config ARCH_BOARD_NUCLEO_F429ZI

Review Comment:
   Thanks for your feedback. I will rework that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] boards/stm32: add support to STM32F401RC-RS485 board [nuttx]

Posted by "rcsim (via GitHub)" <gi...@apache.org>.
rcsim commented on code in PR #10990:
URL: https://github.com/apache/nuttx/pull/10990#discussion_r1367741779


##########
boards/Kconfig:
##########
@@ -1397,6 +1397,8 @@ config ARCH_BOARD_BEAGLEBONE_BLACK
 	---help---
 		This is the port of NuttX to the TI Beaglebone Black board.
 
+
+

Review Comment:
   Thanks for your feedback. I will rework that.



##########
boards/Kconfig:
##########
@@ -1589,6 +1589,17 @@ config ARCH_BOARD_NUCLEO_F401RE
 		This is a minimal configuration that supports low-level test of the
 		Nucleo F401RE in the NuttX source tree.
 
+config ARCH_BOARD_STM32F401RC_RS485
+	bool "STM32F401RC-RS485 Board"
+	depends on ARCH_CHIP_STM32F401RC
+	select ARCH_HAVE_LEDS
+	select ARCH_HAVE_BUTTONS
+	select ARCH_HAVE_IRQBUTTONS
+	---help---
+		This is a minimal configuration that supports low-level test of the
+		STM32F401RC-RS485 in the NuttX source tree.
+
+

Review Comment:
   Hi Alan,
   Extra line has been removed!
   
   Thanks!



##########
boards/Kconfig:
##########
@@ -1432,14 +1434,6 @@ config ARCH_BOARD_PIC32MZ_STARTERKIT
 
 		See www.microchip.com for further information.
 
-config ARCH_BOARD_NUCLEO_F429ZI

Review Comment:
   Pushed a new patch with this fixed.



##########
boards/Kconfig:
##########
@@ -1397,6 +1397,8 @@ config ARCH_BOARD_BEAGLEBONE_BLACK
 	---help---
 		This is the port of NuttX to the TI Beaglebone Black board.
 
+
+

Review Comment:
   Pushed a new patch with this fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] boards/stm32: add support to STM32F401RC-RS485 board [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10990:
URL: https://github.com/apache/nuttx/pull/10990


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org