You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@calcite.apache.org by GitBox <gi...@apache.org> on 2019/02/21 08:51:38 UTC

[GitHub] vlsi commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

vlsi commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…
URL: https://github.com/apache/calcite/pull/1057#discussion_r258829490
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java
 ##########
 @@ -6828,6 +6838,11 @@ private static String sums(int n, boolean c) {
       new Dependent(20, "San Diego"),
     };
 
+    public final DataType[] types = {
 
 Review comment:
   field naming is quite odd.
   Can you please just add `BigDecimal` to `org.apache.calcite.test.ReflectiveSchemaTest.EveryType` instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services