You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by mktal <gi...@git.apache.org> on 2016/07/29 22:06:17 UTC
[GitHub] incubator-madlib pull request #60: Path: Proposed fix for JIRA MADLIB-1012
GitHub user mktal opened a pull request:
https://github.com/apache/incubator-madlib/pull/60
Path: Proposed fix for JIRA MADLIB-1012
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mktal/incubator-madlib bugfix/path_underscore
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/60.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #60
----
commit 54bc0f0a401e8740068ad5717bb72e64adf7ac26
Author: Xiaocheng Tang <xi...@gmail.com>
Date: 2016-07-29T22:05:08Z
Path: Proposed fix for JIRA MADLIB-1012
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #60: Path: Proposed fix for JIRA MADLIB-1012
Posted by mktal <gi...@git.apache.org>.
Github user mktal closed the pull request at:
https://github.com/apache/incubator-madlib/pull/60
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #60: Path: Proposed fix for JIRA MADLIB-1012
Posted by mktal <gi...@git.apache.org>.
Github user mktal commented on the issue:
https://github.com/apache/incubator-madlib/pull/60
Great. I will go ahead and close this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #60: Path: Proposed fix for JIRA MADLIB-1012
Posted by fmcquillan99 <gi...@git.apache.org>.
Github user fmcquillan99 commented on the issue:
https://github.com/apache/incubator-madlib/pull/60
I guess the wider question is are we supporting standard postgres identifiers for symbols?
https://www.postgresql.org/docs/8.2/static/plpgsql-statements.html
So far I have assumed yes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #60: Path: Proposed fix for JIRA MADLIB-1012
Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on the issue:
https://github.com/apache/incubator-madlib/pull/60
\U0001f44d I guess we were looking at the same thing. I already pushed the fix in da582e8. You can close this one when you get the chance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #60: Path: Proposed fix for JIRA MADLIB-1012
Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on the issue:
https://github.com/apache/incubator-madlib/pull/60
Yes the expected behavior is that all standard postgresql identifiers are
allowed.
On Fri, Jul 29, 2016 at 3:15 PM, Frank McQuillan <no...@github.com>
wrote:
> I guess the wider question is are we supporting standard postgres
> identifiers for symbols?
> https://www.postgresql.org/docs/8.2/static/plpgsql-statements.html
>
> So far I have assumed yes
>
--
---------------------------------------------------------
Rahul Iyer
Principal software engineer | Predictive Analytics
*Pivotal**A new platform for a new era*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---