You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by je...@apache.org on 2020/10/26 13:56:17 UTC

[geode] branch develop updated: GEODE-8654: Remove debug logging from AbstractPubSubIntegrationTest (#5668)

This is an automated email from the ASF dual-hosted git repository.

jensdeppe pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new e3efe55  GEODE-8654: Remove debug logging from AbstractPubSubIntegrationTest (#5668)
e3efe55 is described below

commit e3efe552bae5b07188caff4d0d8738931f4134e7
Author: Jens Deppe <jd...@pivotal.io>
AuthorDate: Mon Oct 26 06:55:20 2020 -0700

    GEODE-8654: Remove debug logging from AbstractPubSubIntegrationTest (#5668)
    
    - When this is present, it causes OOM errors when run under
      StressNewTest.
---
 .../internal/executor/pubsub/AbstractPubSubIntegrationTest.java   | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/pubsub/AbstractPubSubIntegrationTest.java b/geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/pubsub/AbstractPubSubIntegrationTest.java
index 4947f60..6e5bf5e 100644
--- a/geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/pubsub/AbstractPubSubIntegrationTest.java
+++ b/geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/pubsub/AbstractPubSubIntegrationTest.java
@@ -32,9 +32,6 @@ import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.stream.Collectors;
 
-import org.apache.logging.log4j.Level;
-import org.apache.logging.log4j.Logger;
-import org.apache.logging.log4j.core.config.Configurator;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.ClassRule;
@@ -42,7 +39,6 @@ import org.junit.Test;
 import redis.clients.jedis.Jedis;
 import redis.clients.jedis.Protocol;
 
-import org.apache.geode.logging.internal.log4j.api.FastLogger;
 import org.apache.geode.logging.internal.log4j.api.LogService;
 import org.apache.geode.redis.mocks.MockBinarySubscriber;
 import org.apache.geode.redis.mocks.MockSubscriber;
@@ -829,10 +825,6 @@ public abstract class AbstractPubSubIntegrationTest implements RedisPortSupplier
   @Test
   public void concurrentSubscribers_andPublishers_doesNotHang()
       throws InterruptedException, ExecutionException {
-    Logger logger = LogService.getLogger("org.apache.geode.redis");
-    Configurator.setAllLevels(logger.getName(), Level.getLevel("DEBUG"));
-    FastLogger.setDelegating(true);
-
     AtomicBoolean running = new AtomicBoolean(true);
 
     Future<Integer> makeSubscribersFuture1 =