Re: [PR] [SPARK-47214][Python] Create UDTF API for 'analyze' method to differentiate constant NULL arguments and other types of arguments [spark]

["ueshin (via GitHub)" <gi...@apache.org>]

ueshin commented on code in PR #45319:
URL: https://github.com/apache/spark/pull/45319#discussion_r1506560801


##########
python/pyspark/sql/worker/analyze_udtf.py:
##########
@@ -84,8 +84,10 @@ def read_arguments(infile: IO) -> Tuple[List[AnalyzeArgument], Dict[str, Analyze
                 value = dt.fromInternal(value)
         else:
             value = None
-        is_table = read_bool(infile)  # is table argument
-        argument = AnalyzeArgument(dataType=dt, value=value, isTable=is_table)
+        is_table = read_bool(infile)
+        is_constant_expression = read_bool(infile)

Review Comment:
   Then receive `is_constant_expression` from `read_bool(inline)` at line 81?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org