You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Oleksiy Sayankin <ol...@gmail.com> on 2018/02/22 15:06:29 UTC
Review Request 65756: HIVE-18060 UpdateInputAccessTimeHook fails for
non-current database
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65756/
-----------------------------------------------------------
Review request for hive, Ashutosh Chauhan and Zoltan Haindrich.
Repository: hive-git
Description
-------
initial commit
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/hooks/UpdateInputAccessTimeHook.java c4856b1
Diff: https://reviews.apache.org/r/65756/diff/1/
Testing
-------
Thanks,
Oleksiy Sayankin
Re: Review Request 65756: HIVE-18060 UpdateInputAccessTimeHook fails
for non-current database
Posted by Zoltan Haindrich <ki...@rxd.hu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65756/#review198127
-----------------------------------------------------------
Could you please add a test for this use case?
The one in the jira description is great
- Zoltan Haindrich
On Feb. 22, 2018, 3:06 p.m., Oleksiy Sayankin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65756/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2018, 3:06 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Zoltan Haindrich.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> initial commit
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/hooks/UpdateInputAccessTimeHook.java c4856b1
>
>
> Diff: https://reviews.apache.org/r/65756/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Oleksiy Sayankin
>
>
Re: Review Request 65756: HIVE-18060 UpdateInputAccessTimeHook fails
for non-current database
Posted by Oleksiy Sayankin <ol...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65756/#review199313
-----------------------------------------------------------
Ship it!
Ship It!
- Oleksiy Sayankin
On March 6, 2018, 7:42 p.m., Oleksiy Sayankin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65756/
> -----------------------------------------------------------
>
> (Updated March 6, 2018, 7:42 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Zoltan Haindrich.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> initial commit
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 4a52eb5
> ql/src/java/org/apache/hadoop/hive/ql/hooks/UpdateInputAccessTimeHook.java c4856b1
> ql/src/test/queries/clientpositive/update_access_time_non_current_db.q PRE-CREATION
> ql/src/test/results/clientpositive/update_access_time_non_current_db.q.out PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65756/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Oleksiy Sayankin
>
>
Re: Review Request 65756: HIVE-18060 UpdateInputAccessTimeHook fails
for non-current database
Posted by Oleksiy Sayankin <ol...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65756/
-----------------------------------------------------------
(Updated March 6, 2018, 7:42 p.m.)
Review request for hive, Ashutosh Chauhan and Zoltan Haindrich.
Changes
-------
Added tests
Repository: hive-git
Description
-------
initial commit
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties 4a52eb5
ql/src/java/org/apache/hadoop/hive/ql/hooks/UpdateInputAccessTimeHook.java c4856b1
ql/src/test/queries/clientpositive/update_access_time_non_current_db.q PRE-CREATION
ql/src/test/results/clientpositive/update_access_time_non_current_db.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/65756/diff/2/
Changes: https://reviews.apache.org/r/65756/diff/1-2/
Testing
-------
Thanks,
Oleksiy Sayankin