You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/29 17:42:28 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on pull request #4576: [Improvement][remote] Refactor remote module to fix code smell
codecov-io edited a comment on pull request #4576:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4576#issuecomment-767433461
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576?src=pr&el=h1) Report
> Merging [#4576](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576?src=pr&el=desc) (db78219) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/891df6d5e29ce9c3a09aaf11cdf96ab31f64ff31?el=desc) (891df6d) will **decrease** coverage by `0.02%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4576 +/- ##
============================================
- Coverage 44.73% 44.71% -0.03%
- Complexity 3343 3352 +9
============================================
Files 530 538 +8
Lines 22838 22996 +158
Branches 2669 2676 +7
============================================
+ Hits 10217 10283 +66
- Misses 11702 11791 +89
- Partials 919 922 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/dolphinscheduler/remote/codec/NettyEncoder.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvZGVjL05ldHR5RW5jb2Rlci5qYXZh) | `86.66% <0.00%> (ø)` | `3.00 <1.00> (ø)` | |
| [...eduler/remote/command/TaskKillResponseCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvVGFza0tpbGxSZXNwb25zZUNvbW1hbmQuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...inscheduler/remote/exceptions/RemoteException.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2V4Y2VwdGlvbnMvUmVtb3RlRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/dolphinscheduler/remote/utils/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0NvbnN0YW50cy5qYXZh) | `71.42% <0.00%> (-11.91%)` | `1.00 <0.00> (ø)` | |
| [...org/apache/dolphinscheduler/remote/utils/Pair.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL1BhaXIuamF2YQ==) | `54.54% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...he/dolphinscheduler/remote/utils/ChannelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0NoYW5uZWxVdGlscy5qYXZh) | `33.33% <20.00%> (-6.67%)` | `1.00 <1.00> (ø)` | |
| [.../apache/dolphinscheduler/remote/utils/IPUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0lQVXRpbHMuamF2YQ==) | `50.81% <27.27%> (-1.64%)` | `16.00 <1.00> (ø)` | |
| [...inscheduler/remote/handler/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2hhbmRsZXIvTmV0dHlDbGllbnRIYW5kbGVyLmphdmE=) | `35.08% <40.00%> (-2.21%)` | `6.00 <0.00> (ø)` | |
| [...inscheduler/remote/handler/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2hhbmRsZXIvTmV0dHlTZXJ2ZXJIYW5kbGVyLmphdmE=) | `45.09% <42.85%> (ø)` | `6.00 <1.00> (+1.00)` | |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `50.70% <56.75%> (-2.08%)` | `11.00 <2.00> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576?src=pr&el=footer). Last update [891df6d...db78219](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4576?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org