[GitHub] [spark] beliefer commented on a diff in pull request #42129: [SPARK-44527][SQL] Replace ScalarSubquery with null if its maxRows is 0

["beliefer (via GitHub)" <gi...@apache.org>]

beliefer commented on code in PR #42129:
URL: https://github.com/apache/spark/pull/42129#discussion_r1276155768


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala:
##########
@@ -88,6 +88,10 @@ object ConstantFolding extends Rule[LogicalPlan] {
           e
       }
 
+    // Replace ScalarSubquery with null if its maxRows is 0
+    case s: ScalarSubquery if s.plan.maxRows.contains(0) =>
+      Literal(null, s.dataType)

Review Comment:
   +1. Move the case here, looks more clear. @wangyum Thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org