[GitHub] [pulsar] MarvinCai opened a new pull request #8840: Make dispatcher pluggable

[GitBox <gi...@apache.org>]

MarvinCai opened a new pull request #8840:
URL: https://github.com/apache/pulsar/pull/8840


   Fixes #8834
   
   ### Motivation
   Make dispatcher pluggable so we can support features like #8544 without changing default dispatcher.
   
   ### Modifications
   Moved Dispatcher interface and abstract classes to dispatcher packages to make package hierarchy a bit cleaner. 
   Add configuration for specifying customized dispatcher for persistent/nonpersistent + subtype combination.
   Create util class to load customized dispatcher from NAR file.
   Create factory class to supply dispatcher based on provided configuration.
   
   ### Verifying this change
   
   Existing test cases passed, added new unit tests for util class and dispatcher factory.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? JavaDocs
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zymap commented on a change in pull request #8840: Make dispatcher pluggable

[GitBox <gi...@apache.org>]

zymap commented on a change in pull request #8840:
URL: https://github.com/apache/pulsar/pull/8840#discussion_r537254481



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -626,6 +626,62 @@
             + " non-backlog consumers as well.")
     private boolean dispatchThrottlingOnNonBacklogConsumerEnabled = false;
 
+    // <-- Pluggable dispatcher -->

Review comment:
       Do we need to add the following configurations into the `broker.conf` and `standalone.conf`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] MarvinCai closed pull request #8840: Make dispatcher pluggable

[GitBox <gi...@apache.org>]

MarvinCai closed pull request #8840:
URL: https://github.com/apache/pulsar/pull/8840


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org