You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by KanakaKumar <gi...@git.apache.org> on 2018/02/16 09:05:05 UTC

[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1972#discussion_r168702275
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/PartitionMapFileStore.java ---
    @@ -279,18 +279,20 @@ public boolean isPartionedSegment() {
        *                      dropped
        * @throws IOException
        */
    -  public void dropPartitions(String segmentPath, List<String> partitionsToDrop, String uniqueId,
    -      boolean partialMatch) throws IOException {
    +  public void dropPartitions(String segmentPath, List<List<String>> partitionsToDrop,
    --- End diff --
    
    All the callers right now has passed only single list for "partitionsToDrop". So I think we can make single list. Is there a special purpose?


---