[GitHub] [superset] villebro commented on pull request #12710: docs: Add support for Hologres

[GitBox <gi...@apache.org>]

villebro commented on pull request #12710:
URL: https://github.com/apache/superset/pull/12710#issuecomment-766770728


   > > Thanks for the contribution @TimothyDing ! Given that Hologres is Postgres 11 compatible, I assume all time grains and other properties defined in the Postgres db engine spec are valid?
   
   To be fully supported, the [time grains](https://github.com/apache/superset/blob/master/superset/db_engine_specs/postgres.py#L48-L58), [epoch conversion function](https://github.com/apache/superset/blob/master/superset/db_engine_specs/postgres.py#L69-L71) and [datetime conversion functions](https://github.com/apache/superset/blob/master/superset/db_engine_specs/postgres.py#L115-L122) should preferably be identical to the base Postgres dialect, otherwise Superset might not function properly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org