[jira] [Commented] (THRIFT-2911) fix c++ version zeromq transport, the old version cannot work

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368354#comment-14368354 ] 

ASF GitHub Bot commented on THRIFT-2911:
----------------------------------------

Github user jfarrell closed the pull request at:

    https://github.com/apache/thrift/pull/339


> fix c++ version zeromq transport, the old version cannot work
> -------------------------------------------------------------
>
>                 Key: THRIFT-2911
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2911
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>             Fix For: 0.9.3
>
>
> GitHub user littletiny opened a pull request:
>     https://github.com/apache/thrift/pull/315
>     fix c++ version zeromq transport, the old version cannot work
>     fix c++ version zeromq transport, the old version cannot work
>     we need to override
>     ```
>      TTransport::write_virt  TTransport::read_virt
>     ```
>     instead of
>     ```
>      TTransport::write TTransport::read
>     ```
> You can merge this pull request into a Git repository by running:
>     $ git pull https://github.com/littletiny/thrift master
> Alternatively you can review and apply these changes as the patch at:
>     https://github.com/apache/thrift/pull/315.patch
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>     This closes #315
>     
> ----
> commit bf792bb89cab8e42bbde6e9965bef5c8f2deacd0
> Author: tiny <lo...@gmail.com>
> Date:   2014-12-11T06:22:29Z
>     fix c++ version zeromq transport, the old version cannot work
> ----



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)