[GitHub] [geode] Bill commented on pull request #4743: GEODE-7808: standardize on use of HostAndPort to form client-side connections

["Bill (GitHub)" <gi...@apache.org>]

Only a few methods on`SocketCreator` are used by this class. Most of them have to do with configuration. The same can be said of use of `SocketCreator` by the two other sibling classes: `SCClientSocketCreator`, `SCAdvancedSocketCreator`. That being the case I wonder if it would be reasonable to make e.g. a `SocketConfiguration` interface and use that instead here.

The only exception I see to this situation is that `SCAdvancedSocketCreator.connect` calls `SocketCreator.configureClientSSLSocket()`. But perhaps that method could be moved from `SocketCreator` to `SCAdvancedSocketCreator`. That method, in turn, needs some SSL configuration settings, but it should be able to access all those from the `SocketConfiguration`.

[ Full content available at: https://github.com/apache/geode/pull/4743 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org