[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1227: MINIFICPP-1222 Remove engine queue for ExecutePythonProcessor

[GitBox <gi...@apache.org>]

lordgamez commented on pull request #1227:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1227#issuecomment-1004130214


   > Looks good, but [ExecuteScript](https://github.com/apache/nifi-minifi-cpp/blob/main/extensions/script/ExecuteScript.cpp#L93) also uses engine queues (for both python and lua) so this problem should be there for ExecuteScript while in python mode.
   > 
   > On the other hand lua doesnt have a global interpreter lock and ExecuteScript doesnt really allow stateful scripts, so the engine queue should theoretically work there (everything is contained in the sol::state member of LuaScriptEngine.h), but then I guess the original problem detailed in https://issues.apache.org/jira/browse/MINIFICPP-1222 is still present in ExecuteScript Lua mode.
   
   That's a good point, I think that should also be fixed with a solution that allows us to have concurrency with Lua executions with the set limit of maximum concurrent tasks, but handling python executions differently by only having a single script engine for that. I created a Jira ticket for that rework: https://issues.apache.org/jira/browse/MINIFICPP-1706


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org