You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/12/23 17:07:11 UTC
[GitHub] [cordova-plugin-wkwebview-engine] Ju-NXH opened a new pull request #184: (ios) Add pref to accept untrusted certificates
Ju-NXH opened a new pull request #184:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/184
### Platforms affected
iOS
### Motivation and Context
This change adds the ability to accept untrusted certificates (self-signed certificates for instance) thanks to a new preference in the `config.xml` file. It was needed because our development team test our mobile app along with a server instance hosted on their workstation, and this local instance uses self-signed certificates.
### Description
With this feature, you don't need to do anything on the device to be able to access web resources hosted on a server that uses self-signed certificates. To make a device accept or reject untrusted certificates, a new preference needs to be defined in the `config.xml` file (see README). Then, the corresponding Objective-C code controlled by the preference intercepts the HTTPS request right when iOS evaluates the certificate and dynamically adds an exception so that all certificates get accepted.
### Testing
This feature was tested with our mobile app.
Setting the `AllowUntrustedCerts` preference to `true` for our debug builds allows us to access HTTPS resources hosted on a web server that uses self-signed certificates, setting it to false prevents us from doing so.
### Checklist
I have no MacOS machine available to run the tests or to add new ones.
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] breautek commented on pull request #184: (ios) Add pref to accept untrusted certificates
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #184:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/184#issuecomment-761893324
> Hi, would there be someone available to review this PR? @erisu @timbru31 @breautek
Thank you for this PR, however I'm not sure if this will ever actually be released.
Pending an official vote -- this plugin is going to be deprecated. Apple enforces WKWebView now, so it is implemented in the core platform as of cordova-ios@6; making this plugin obsolete moving forward.
Something like this might be better to be implemented in the core cordova-ios package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] Ju-NXH commented on pull request #184: (ios) Add pref to accept untrusted certificates
Posted by GitBox <gi...@apache.org>.
Ju-NXH commented on pull request #184:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/184#issuecomment-755762148
Hi, would there be someone available to review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] Ju-NXH commented on pull request #184: (ios) Add pref to accept untrusted certificates
Posted by GitBox <gi...@apache.org>.
Ju-NXH commented on pull request #184:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/184#issuecomment-762305524
Makes sense, thank you @breautek.
I created this PR because we're still using cordova-ios@5.1.1 along with this plugin for now.
I'll try to port this feature to cordova-ios@6 when we'll upgrade our app to use it, and I'll create another PR for cordova-ios then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-wkwebview-engine] Ju-NXH edited a comment on pull request #184: (ios) Add pref to accept untrusted certificates
Posted by GitBox <gi...@apache.org>.
Ju-NXH edited a comment on pull request #184:
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/184#issuecomment-755762148
Hi, would there be someone available to review this PR? @erisu @timbru31 @breautek
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org