You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/10/14 14:16:35 UTC

[GitHub] [tinkerpop] mmadoo commented on pull request #1342: TINKERPOP-2436 The gremlin server starts even if all graphs instantiation has failed

mmadoo commented on pull request #1342:
URL: https://github.com/apache/tinkerpop/pull/1342#issuecomment-708433204


   I do not have change the  Upgrade Documentation as this GraphManager is not the default, so it will not break anything. An option is to set like it in 3.4 branch and to make it default in master.
   
   Also, why does DefaultGraphManager was final (class and methods), this make harder to do a extension on this class.  I have only removed final on class (I like the Jetty approach that allows override at nearly any level)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org