You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Kay Kay (JIRA)" <ji...@apache.org> on 2008/12/22 20:42:44 UTC
[jira] Created: (SOLR-935) DataImportHandler: Add logging to record
failure to acquire lock by DataImporter for a given request
DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request
-----------------------------------------------------------------------------------------------------
Key: SOLR-935
URL: https://issues.apache.org/jira/browse/SOLR-935
Project: Solr
Issue Type: Improvement
Environment: Java 6, Tomcat 6.0.18
Reporter: Kay Kay
Fix For: 1.4
There is a possibility of 2 threads to be in runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-935) DataImportHandler: Add logging to record
failure to acquire lock by DataImporter for a given request
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated SOLR-935:
-------------------------
Priority: Major (was: Minor)
Increasing priority since in a workflow scenario with more than 2 delta-import requests received at the server - we need some way to track in the debug log that one of them actually failed and need to be tried again.
> DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request
> -----------------------------------------------------------------------------------------------------
>
> Key: SOLR-935
> URL: https://issues.apache.org/jira/browse/SOLR-935
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6.0.18
> Reporter: Kay Kay
> Fix For: 1.4
>
> Attachments: SOLR-935.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in DataImporter:runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-935) DataImportHandler: Add logging to record
failure to acquire lock by DataImporter for a given request
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-935:
----------------------------
Attachment: SOLR-935.patch
the partial fix. It logs a warning if it fails to acquire a lock
I am still not convinced of the EventListener part
> DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request
> -----------------------------------------------------------------------------------------------------
>
> Key: SOLR-935
> URL: https://issues.apache.org/jira/browse/SOLR-935
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6.0.18
> Reporter: Kay Kay
> Assignee: Noble Paul
> Fix For: 1.4
>
> Attachments: SOLR-935.patch, SOLR-935.patch, SOLR-935.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in DataImporter:runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SOLR-935) DataImportHandler: Add logging to
record failure to acquire lock by DataImporter for a given request
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul reassigned SOLR-935:
-------------------------------
Assignee: Noble Paul
> DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request
> -----------------------------------------------------------------------------------------------------
>
> Key: SOLR-935
> URL: https://issues.apache.org/jira/browse/SOLR-935
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6.0.18
> Reporter: Kay Kay
> Assignee: Noble Paul
> Fix For: 1.4
>
> Attachments: SOLR-935.patch, SOLR-935.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in DataImporter:runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-935) DataImportHandler: Add logging to record
failure to acquire lock by DataImporter for a given request
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated SOLR-935:
-------------------------
Description:
There is a possibility of 2 threads to be in DataImporter:runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
was:
There is a possibility of 2 threads to be in runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
> DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request
> -----------------------------------------------------------------------------------------------------
>
> Key: SOLR-935
> URL: https://issues.apache.org/jira/browse/SOLR-935
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6.0.18
> Reporter: Kay Kay
> Fix For: 1.4
>
> Attachments: SOLR-935.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in DataImporter:runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-935) DataImportHandler: Add logging to
record failure to acquire lock by DataImporter for a given request
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662965#action_12662965 ]
Kay Kay commented on SOLR-935:
------------------------------
What it really means is that - after the full/delta import request is submitted - it did not launch at all in the server side, but rather failed quietly.
It is important from a debugging perspective that we see something like a "warning: data import did not launch because of mutex acquisition failure. Please retry" .
> DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request
> -----------------------------------------------------------------------------------------------------
>
> Key: SOLR-935
> URL: https://issues.apache.org/jira/browse/SOLR-935
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6.0.18
> Reporter: Kay Kay
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-935.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in DataImporter:runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-935) DataImportHandler: Add logging to
record failure to acquire lock by DataImporter for a given request
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662772#action_12662772 ]
Shalin Shekhar Mangar commented on SOLR-935:
--------------------------------------------
We can add this piece of logging but what benefit will that provide? Will it scare users when they see something like "Mutex Acquisition failure" in the logs?
> DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request
> -----------------------------------------------------------------------------------------------------
>
> Key: SOLR-935
> URL: https://issues.apache.org/jira/browse/SOLR-935
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6.0.18
> Reporter: Kay Kay
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-935.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in DataImporter:runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-935) DataImportHandler: Add logging to
record failure to acquire lock by DataImporter for a given request
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709085#action_12709085 ]
Shalin Shekhar Mangar commented on SOLR-935:
--------------------------------------------
The logging is fine. But I am not sure of the utility of the event listener. Why would one configure an import to be run so frequently that it can trigger the failure to acquire lock? What useful action can one take in this scenario?
> DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request
> -----------------------------------------------------------------------------------------------------
>
> Key: SOLR-935
> URL: https://issues.apache.org/jira/browse/SOLR-935
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6.0.18
> Reporter: Kay Kay
> Fix For: 1.4
>
> Attachments: SOLR-935.patch, SOLR-935.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in DataImporter:runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-935) DataImportHandler: Add logging to
record failure to acquire lock by DataImporter for a given request
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709088#action_12709088 ]
Kay Kay commented on SOLR-935:
------------------------------
*Makes it easy for a plugin to keep track of failures when the delta import did not launch at all*
Otherwise those frequent imports ( due to a code / workflow error ) would go unnoticed.
> DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request
> -----------------------------------------------------------------------------------------------------
>
> Key: SOLR-935
> URL: https://issues.apache.org/jira/browse/SOLR-935
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6.0.18
> Reporter: Kay Kay
> Fix For: 1.4
>
> Attachments: SOLR-935.patch, SOLR-935.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in DataImporter:runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-935) DataImportHandler: Add logging to record
failure to acquire lock by DataImporter for a given request
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-935:
----------------------------
Fix Version/s: (was: 1.4)
1.5
I feel that the original concern is addressed. I am pushing it to 1.5 so that we can have a detailed look at this later
> DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request
> -----------------------------------------------------------------------------------------------------
>
> Key: SOLR-935
> URL: https://issues.apache.org/jira/browse/SOLR-935
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6.0.18
> Reporter: Kay Kay
> Assignee: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-935.patch, SOLR-935.patch, SOLR-935.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in DataImporter:runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-935) DataImportHandler: Add logging to
record failure to acquire lock by DataImporter for a given request
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711486#action_12711486 ]
Noble Paul commented on SOLR-935:
---------------------------------
committed revision : 776965
> DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request
> -----------------------------------------------------------------------------------------------------
>
> Key: SOLR-935
> URL: https://issues.apache.org/jira/browse/SOLR-935
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6.0.18
> Reporter: Kay Kay
> Assignee: Noble Paul
> Fix For: 1.4
>
> Attachments: SOLR-935.patch, SOLR-935.patch, SOLR-935.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in DataImporter:runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-935) DataImportHandler: Add logging to record
failure to acquire lock by DataImporter for a given request
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated SOLR-935:
-------------------------
Attachment: SOLR-935.patch
> DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request
> -----------------------------------------------------------------------------------------------------
>
> Key: SOLR-935
> URL: https://issues.apache.org/jira/browse/SOLR-935
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6.0.18
> Reporter: Kay Kay
> Fix For: 1.4
>
> Attachments: SOLR-935.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-935) DataImportHandler: Add logging to record
failure to acquire lock by DataImporter for a given request
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated SOLR-935:
-------------------------
Component/s: contrib - DataImportHandler
> DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request
> -----------------------------------------------------------------------------------------------------
>
> Key: SOLR-935
> URL: https://issues.apache.org/jira/browse/SOLR-935
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6.0.18
> Reporter: Kay Kay
> Fix For: 1.4
>
> Attachments: SOLR-935.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-935) DataImportHandler: Add logging to record
failure to acquire lock by DataImporter for a given request
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated SOLR-935:
-------------------------
Priority: Minor (was: Major)
> DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request
> -----------------------------------------------------------------------------------------------------
>
> Key: SOLR-935
> URL: https://issues.apache.org/jira/browse/SOLR-935
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6.0.18
> Reporter: Kay Kay
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-935.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in DataImporter:runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-935) DataImportHandler: Add logging to record
failure to acquire lock by DataImporter for a given request
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated SOLR-935:
-------------------------
Attachment: SOLR-935.patch
New Patch submitted for workflow modification to track failures better.
- Logging is removed in favor of more granular notification.
Context:
New field called EventStatus added to Context ( default value - SUCCESS)
During failure - another event is launched , with the EventStatus field in the Context set to Failure.
Makes it easy for a plugin to keep track of failures when the delta import did not launch at all (due to synch. issues), compared to log based debugging.
This patch is independent of SOLR-972, but would be extremely efficient if SOLR-972 is applied though.
> DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request
> -----------------------------------------------------------------------------------------------------
>
> Key: SOLR-935
> URL: https://issues.apache.org/jira/browse/SOLR-935
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Environment: Java 6, Tomcat 6.0.18
> Reporter: Kay Kay
> Fix For: 1.4
>
> Attachments: SOLR-935.patch, SOLR-935.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in DataImporter:runCmd, until before importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.