"svn update --set-depth=exclude" exits prematurely, leaving repo in need of cleanup

[Jim Barry <ji...@chez-jim.net>]

When excluding a subtree from the working copy, if any unversioned items 
are present then the svn update command fails silently, leaving the 
working copy locked and requiring cleanup.

This is with version 1.9.4, the current release.

Reproducing the problem is fairly straightforward. Create a new repo (or 
just use an existing one):

$ svnadmin create repo
$ svn checkout file://`pwd`/repo wc
Checked out revision 0.

Add a directory and subdirectory:

$ cd wc
$ mkdir dir
$ mkdir dir/subdir1
$ svn add dir
A         dir
A         dir/subdir1
$ svn commit -m "Added dir"
Adding         dir
Adding         dir/subdir1
Committing transaction...
Committed revision 1.

Create another subdirectory, without adding it to the repo:

$ mkdir dir/subdir2

Now, let's exclude "dir" from the working copy:

$ svn update --set-depth exclude dir
D         dir/subdir1

OK, so svn says it has deleted "dir/subdir1", but has left "dir" alone. 
Fair enough, as "dir" contains the unversioned item "subdir2". 

But wait - let's take a peek:

$ ls dir
subdir1  subdir2

Huh? What is "subdir1" still doing there? Let's quickly do a regular 
update:

$ svn update
svn: E155037: Previous operation has not finished; run 'cleanup' if it 
was interrupted

Oooh, that's not good! Let's take a closer look:

$ svn status
  L     .
  L     dir
?       dir\subdir1
?       dir\subdir2

Yikes! Looks like svn bailed out without finishing the job.

This must be a bug, right? Any chance somebody can take a look at it?

Thanks!

Re: "svn update --set-depth=exclude" exits prematurely, leaving repo in need of cleanup

[Jim Barry <ji...@chez-jim.net>]

Branko Čibej wrote:
> Please file a bug with the reproduction script.

OK, the issue number is SVN-4642.

Thanks

Re: "svn update --set-depth=exclude" exits prematurely, leaving repo in need of cleanup

[Branko Čibej <br...@apache.org>]

On 07.07.2016 12:36, Jim Barry wrote:
> Branko \u010cibej writes:
>> I can reproduce this with 1.9.4 and trunk ... definitely a bug, only
>> dir/subdir2 should be left (since dir/subdir2 is unversioned content of
>> dir).
> Thanks Brane. Would it be possible for an svn dev to take this on?
>
> By the way, I just checked it with 1.8.16 and everything works as 
> expected, so it seems this bug was introduced in 1.9.x.

Please file a bug with the reproduction script.

-- Brane

Re: "svn update --set-depth=exclude" exits prematurely, leaving repo in need of cleanup

[Jim Barry <ji...@chez-jim.net>]

Branko Čibej writes:
> I can reproduce this with 1.9.4 and trunk ... definitely a bug, only
> dir/subdir2 should be left (since dir/subdir2 is unversioned content of
> dir).

Thanks Brane. Would it be possible for an svn dev to take this on?

By the way, I just checked it with 1.8.16 and everything works as 
expected, so it seems this bug was introduced in 1.9.x.

- Jim

Re: "svn update --set-depth=exclude" exits prematurely, leaving repo in need of cleanup

[Branko Čibej <br...@apache.org>]

On 05.07.2016 16:00, Jim Barry wrote:
>> This must be a bug, right? Any chance somebody can take a look at it?
> [... tumbleweed ...]
>
> Anyone? Should I file a bug report?

I can reproduce this with 1.9.4 and trunk ... definitely a bug, only
dir/subdir2 should be left (since dir/subdir2 is unversioned content of
dir).

-- Brane

Re: "svn update --set-depth=exclude" exits prematurely, leaving repo in need of cleanup

[Jim Barry <ji...@chez-jim.net>]

> This must be a bug, right? Any chance somebody can take a look at it?

[... tumbleweed ...]

Anyone? Should I file a bug report?

Thanks