You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by pluswave <gi...@git.apache.org> on 2015/07/01 09:12:35 UTC
[GitHub] cordova-plugin-camera pull request: [android] allowedit: fix not C...
GitHub user pluswave opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/103
[android] allowedit: fix not Cropping after taking picture from camera
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pluswave/cordova-plugin-camera master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/103.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #103
----
commit ea12fd08832b160ad87e59094e89c62bd3e3febc
Author: Zhang Zengbo <ze...@gmail.com>
Date: 2015-07-01T07:05:41Z
[android] allowedit: fix not Cropping after taking picture from camera
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: [android] allowedit: fix not C...
Posted by pluswave <gi...@git.apache.org>.
Github user pluswave commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/103#issuecomment-117504586
for allowedit option, the imageUrl inside processResultFromCamera is wrong (always get the original image), and sourcePath is not used. So this patch fix the issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: [android] allowedit: fix not C...
Posted by pluswave <gi...@git.apache.org>.
Github user pluswave closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/103
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: [android] allowedit: fix not C...
Posted by pluswave <gi...@git.apache.org>.
Github user pluswave commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/103#issuecomment-141929598
Just checked the master branch, it seems that the issue is fixed by dca8bd1943449b201f73f860d45b28ab84676074 , so this pull request is no longer needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: [android] allowedit: fix not C...
Posted by hgehlhausen <gi...@git.apache.org>.
Github user hgehlhausen commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/103#issuecomment-141544464
####Hey
Did this get merged in yet?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: [android] allowedit: fix not C...
Posted by Anu2g <gi...@git.apache.org>.
Github user Anu2g commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/103#issuecomment-138353711
This pull request worked fantastically for my team. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org