You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Pedro Santos (Jira)" <ji...@apache.org> on 2024/11/22 22:07:00 UTC

[jira] [Created] (WICKET-7134) To refactor Form processing code

Pedro Santos created WICKET-7134:
------------------------------------

             Summary: To refactor Form processing code
                 Key: WICKET-7134
                 URL: https://issues.apache.org/jira/browse/WICKET-7134
             Project: Wicket
          Issue Type: Improvement
            Reporter: Pedro Santos


Form code has a few places where nested form processing is done by a visit while the current form is processed outside that visit. For instance:

protected final void markFormComponentsValid() {
   markNestedFormComponentsValid();
   internalMarkFormComponentsValid();
}

private void markNestedFormComponentsValid() {
   visitFormsPostOrder(this, (form, visit) -> {
      if (form == Form.this) {
         return;
      }
      if (form.isSubmitted()) {
         form.internalMarkFormComponentsValid();
      }
   });
}

Those pieces of code can be simplified by moving the entire processing to the visit. Also, by the point Form#isSubmitted test is being done, the form isn't already submitted. The test is just there to replace the form.isVisible/Enabled one, but without correctly communicating its function to the code maintainer.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)