You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/30 02:26:57 UTC

[GitHub] [tvm] codeislife99 edited a comment on pull request #7375: Support negative pad values

codeislife99 edited a comment on pull request #7375:
URL: https://github.com/apache/tvm/pull/7375#issuecomment-770140715


   @anijain2305 @trevor-m 
   Please re-review. 
   One dilemna here is that when shape is dynamic I cannot check if the existing shape + padding would be greater than zero in infertype. This will lead to a memory error during executing when it wont be able to create memory for negative tensor sizes. And the error would be quite bad because the developer/user would not have a clue where it is coming from in a big model. 
   
   Does anyone have any idea of how to solve this ? Should we display a warning whenever we encounter negative padding ? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org